yazi, yazi-unwrapped: 0.3.3 -> 0.4.0 #363326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadir-ishiguro
force-pushed
the
update-yazi-unwrapped
branch
from
ac8aaaa to
fac942e
Compare
nadir-ishiguro
changed the title
|
Gliczy
added
the
12.approvals: 1
llakala
reviewed
Dec 8, 2024
There was a problem hiding this comment.
Builds and functions on my machine. I do get these warnings while building:
warning: [email protected]: not within a suitable 'git' worktree!
warning: [email protected]: VERGEN_GIT_COMMIT_DATE set to default
warning: [email protected]: VERGEN_GIT_SHA overidden
Probably fine, but thought I should mention it.
It's normal, we do override it. |
|
XYenon
approved these changes
Dec 9, 2024
XYenon
added
12.approvals: 2
|
@ofborg build yazi |
getchoo
approved these changes
Dec 9, 2024
getchoo
added
12.approvals: 3+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: https://github.com/sxyazi/yazi/releases/tag/v0.4.0
There are some breaking changes.
The one I addressed is the switch from ffmpegthumbnailer to ffmpeg/ffprobe
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.