-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos-containers: add networkNamespace option #359352
nixos-containers: add networkNamespace option #359352
Conversation
d52d621
to
a0c5593
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4980 |
@ofborg test containers-restart_networking |
Test is broken on master too, I'm trying to fix it...
Network config uses same ip on two different interfaces:
So I don't think that |
88e50dc
to
fce9607
Compare
fce9607
to
5e4c8f1
Compare
@ofborg test containers-restart_networking |
This PR implements the network namespace option for the systemd-nspawn module (nixos-containers).
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.