nheko: add identicons support

[unclechu]

Motivation for this change

Nheko has support for identicons. There is a checkbox in the settings of nheko but it wasn’t clickable because the dependency (“qt-jdenticon” plugin) was missing.

This change adds “qt-jdenticon” as a new package (Qt plugin) and as a dependency for Nheko. This package is maintained by Nheko team.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.05 Release Notes (or backporting 21.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[unclechu]

Context reference: #150437 (comment)

[doronbehar]

And please change the git history into two commits:

libsForQt5.qt-jdenticon: init at 0.2.1

And:

nheko: Add support for `jdenticon`

Or alike.

[doronbehar]

qt-jdenticon is meant for qt5, and nheko is built with qt6. Closing.

[unclechu]

@doronbehar

qt-jdenticon is meant for qt5, and nheko is built with qt6. Closing.

It works for me on Nheko build for Qt6. Here is a demonstration:

https://github.com/unclechu/nixos-config/blob/1fcdb7e65cb21e523c81adc5c6d5cbea947a6cd5/apps/nheko/default.nix#L28-L59

https://github.com/unclechu/nixos-config/blob/1fcdb7e65cb21e523c81adc5c6d5cbea947a6cd5/apps/nheko/default.nix#L73-L76

It works both for Qt5 and Qt6 just fine.

[doronbehar]

Hmm OK, then please add it to both qt5-packages.nix and qt6-packages.nix, as I asked you already 3 years ago :) fix the merge conflicts, and we'll see. Also, remember to separate the qt-jdenticon: init commit to a separate commit.

[unclechu]

@doronbehar I fixed everything, please have another look.

I think I was wrong about qt-jdenticon was working both for Qt5 and Qt6. 0.2.* was made for Qt5 but I was actually using 0.3.0 that is made to work with Qt6, with newer Nheko. So I didn’t add the package to qt5-packages.nix, I assume it won’t work judging by CMake configuration file which only mentions Qt6. But I added the package to qt6-packages.nix (removed from all-packages.nix).

• So now it’s 0.3.0 version instead of 0.2.1
• I made separate commits for adding qt-jdenticon package and using the package for Nheko
• Applied new nixfmt
• Tested that the library package builds like this: nix-build -E 'with import ./. {}; qt6Packages.qt-jdenticon'
• And built Nheko like this: nix-build -E 'with import ./. { config.permittedInsecurePackages=["olm-3.2.16"]; }; nheko' and tested that jdenticons are rendered properly:

[doronbehar]

I added a few minor modifications which were hard to explain in a review :), and forced pushed. I'm sure you won't mind.