Replace HashMap with LinkedHashMap => deterministic iteration order

NitorCreations · Aug 13, 2014 · 811e9b0 · 811e9b0
1 parent 30a46e8
commit 811e9b0
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/...ine/src/main/java/com/nitorcreations/nflow/engine/workflow/instance/WorkflowInstance.java b/...ine/src/main/java/com/nitorcreations/nflow/engine/workflow/instance/WorkflowInstance.java
@@ -1,6 +1,6 @@
 package com.nitorcreations.nflow.engine.workflow.instance;
 
-import java.util.HashMap;
+import java.util.LinkedHashMap;
 import java.util.List;
 import java.util.Map;
 
@@ -54,8 +54,8 @@ public static class Builder {
     String stateText;
     DateTime nextActivation;
     boolean processing;
-    final HashMap<String, String> originalStateVariables = new HashMap<>();
-    final HashMap<String, String> stateVariables = new HashMap<>();
+    final Map<String, String> originalStateVariables = new LinkedHashMap<>();
+    final Map<String, String> stateVariables = new LinkedHashMap<>();
     List<WorkflowInstanceAction> actions;
     int retries;
     DateTime created;

diff --git a/nflow-jetty/src/main/java/com/nitorcreations/nflow/jetty/StartNflow.java b/nflow-jetty/src/main/java/com/nitorcreations/nflow/jetty/StartNflow.java
@@ -12,7 +12,7 @@
 import java.nio.file.Paths;
 import java.util.Arrays;
 import java.util.Collections;
-import java.util.HashMap;
+import java.util.LinkedHashMap;
 import java.util.LinkedHashSet;
 import java.util.Map;
 import java.util.Set;
@@ -60,7 +60,7 @@ public StartNflow registerSpringContext(Class<?> ... springContextClass) {
   }
 
   public JettyServerContainer startJetty(int port, String env, String profiles) throws Exception {
-    return startJetty(port, env, profiles, new HashMap<String, Object>());
+    return startJetty(port, env, profiles, new LinkedHashMap<String, Object>());
   }
 
   public JettyServerContainer startJetty(int port, String env, String profiles, Map<String, Object> properties) throws Exception {

diff --git a/nflow-tests/src/test/java/com/nitorcreations/nflow/tests/runner/NflowServerRule.java b/nflow-tests/src/test/java/com/nitorcreations/nflow/tests/runner/NflowServerRule.java
@@ -6,7 +6,7 @@
 import static org.apache.commons.lang3.StringUtils.right;
 import static org.junit.Assert.assertTrue;
 
-import java.util.HashMap;
+import java.util.LinkedHashMap;
 import java.util.Map;
 import java.util.concurrent.atomic.AtomicReference;
 
@@ -35,7 +35,7 @@ public static class Builder {
     int port = 0;
     String env = "local";
     String profiles = "";
-    final Map<String, Object> props = new HashMap<>();
+    final Map<String, Object> props = new LinkedHashMap<>();
     {
       props.put("nflow.db.h2.tcp.port", "");
       props.put("nflow.db.h2.console.port", "");