Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: only rerun tests from past run when we fail to find specs, and al… #90

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Saqibm128
Copy link

…low option to not rerun all

@Saqibm128 Saqibm128 changed the title feat: only rerun tests from past run if we fail to find specs, and al… feat: only rerun tests from past run when we fail to find specs, and al… Apr 18, 2018
@NickTomlin
Copy link
Owner

Could you provide some context on this pull request? I'm not sure I understand the use case. Thanks!

@Saqibm128
Copy link
Author

Saqibm128 commented Apr 19, 2018

allowing specs to restart completely in every scenario where the parser fails to find any tests but protractor still fails can be problematic. for example, some of the parsers fail if there is an error in either the before each or after each hook. in some cases, it may be better to just ignore the failure.

@Saqibm128
Copy link
Author

Saqibm128 commented Apr 19, 2018

if the option to allow specs to restart when no specs are identified is allowed, at the very least we should keep track of the tests which have definitely passed and avoid restarting them. if they are restarted, they may flake again, even though they may have already passed before in a previous run. instead, let's just attempt tests from the previous attempt, i.e. redo tests from the last attempt we failed to parse, not all test specs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants