fix(evm): proper block gas calculation in precompile calls #2131
Conversation
WalkthroughThis pull request introduces updates to the Nibiru EVM project's changelog and several code modifications related to gas management and testing. The changes focus on improving block gas calculation in precompile calls, refining gas meter handling in test suites, and updating documentation to reflect recent developments. The modifications aim to enhance the accuracy of gas consumption tracking and provide a clear record of project improvements. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
x/evm/precompile/funtoken_test.go (2)
174-175: Refactor repeated ResetGasMeter callInvoking
deps.ResetGasMeter()right before the contract call is appropriate for measuring gas usage, but consider DRY (Don’t Repeat Yourself) by extracting this into a helper if it appears frequently throughout the tests.
258-259: Reinitialize gas meter consistentlyOnce again,
deps.ResetGasMeter()is invoked. Confirm if each test block truly needs an independent reset or if a shared setup function could centralize this logic, improving maintainability.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
CHANGELOG.md(1 hunks)x/evm/keeper/call_contract.go(1 hunks)x/evm/keeper/funtoken_from_coin_test.go(1 hunks)x/evm/precompile/funtoken_test.go(2 hunks)
✅ Files skipped from review due to trivial changes (1)
- x/evm/keeper/funtoken_from_coin_test.go
🔇 Additional comments (3)
x/evm/keeper/call_contract.go (2)
111-111: Question the full gas consumption on error case
On error, the code consumes the entire gas limit by calling k.ResetGasMeterAndConsumeGas(ctx, ctx.GasMeter().Limit()). Confirm if the intended behavior is to fully charge for gas in all error cases, regardless of how much gas was actually used.
115-119: Validate double reset scenario and final block gas usage
After blockGasUsed is calculated, the code resets the gas meter again. Verify that calling ResetGasMeterAndConsumeGas again (after line 111’s usage) does not inadvertently double charge or overshadow prior consumption. Ensure that it reflects the precise final usage without incorrectly penalizing the user or contract.
CHANGELOG.md (1)
54-54: Looks good
The new entry under Nibiru EVM is consistent with the existing style, properly referencing pull request #2131 and describing the fix. No further changes needed.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2131 +/- ##
==========================================
+ Coverage 64.93% 64.95% +0.02%
==========================================
Files 273 273
Lines 21656 21663 +7
==========================================
+ Hits 14063 14072 +9
+ Misses 6617 6615 -2
Partials 976 976
|
There was a problem hiding this comment.
This doesn't necessarily implement the desired functionality. Please see my comment at https://github.com/code-423n4/2024-11-nibiru-findings/issues/46#issuecomment-2564154771.
Specifically, we need to always add to block gas used, and never set the current tx's context's gas used to the blockGasUsed or else we'll OOG panic in later txs in the block.
Summary by CodeRabbit
New Features
Bug Fixes
Tests