fix: add sector value to sector insight api #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songyi00
reviewed
Feb 29, 2024
| .groupBy(stock.id, stock.price) | ||
| .orderBy(dividendYield.desc()) | ||
| .having(dividendYield.loe(MAX_DIVIDEND_YIELD)) |
There was a problem hiding this comment.
혹시 loe가 low or equal 이 맞다면 이하가 아니라 미만이 되어야 할 것 같습니다!! :>
| CONGLOMERATES("Conglomerates"), | ||
| ETF("ETF"), | ||
| ETC("ETC"); | ||
| TECHNOLOGY("Technology", "TECHNOLOGY"), |
There was a problem hiding this comment.
요거 value 추가된 이유가 있을까요?? enum 과 동일해서 그대로 사용해도 될 것 같아서요!!
There was a problem hiding this comment.
앗 혹시 저 enum 값을 그대로 사용할 수 있는 방법이 있나요?! String으로 받아서 비교하려면 저는 필요한걸로 생각했어요...!!
| int expectedMonth = 3; | ||
| int expectedDayOfMonth = 1; | ||
| int lastYear = LocalDate.now().getYear() - 1; | ||
| Instant exDividendDate = LocalDate.of(lastYear, 3, 1).atStartOfDay().toInstant(UTC); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
close: #75
작업 내역
변경사항
PR 특이 사항