feat: implement stock domain #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chominho96
requested changes
Jan 20, 2024
|
|
||
| private double price; | ||
|
|
||
| private Double volume; |
There was a problem hiding this comment.
거래량은 정수로 표현될 수 있다고 생각하는데 double형을 쓰신 이유가 있을까요???
There was a problem hiding this comment.
@chominho96 혹시 몰라서 일단 실수형으로 넣어놓았어요! API 스펙 확인했는데 정수로 바꿔도 될 것 같습니다 :)
There was a problem hiding this comment.
거래량은 화면에서 표현도 정수형으로 될거 같아서 저는 정수형으로 저장되어도 괜찮다고 생각해요!!
|
|
||
| private String industry; | ||
|
|
||
| private double price; |
There was a problem hiding this comment.
null 체크가 되려면 Double 형이 맞을거 같은데 어떻게 생각하시나요??
There was a problem hiding this comment.
@chominho96 오 이건 오타(?)입니다. 수정해놓을게요!!
| RealEstate, | ||
| Energy, | ||
| Utilities, | ||
| ETC |
There was a problem hiding this comment.
약간 관례?적으로 enum에서 상수는 모두 대문자로 표기한다고 알고 있어서 이 부분 같이 맞춰보면 좋을거 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
close: #3
작업 내역