fix: 편지 상세 조회, 자유롭게 쓰는 질문에 대한 처리 #3

Nexters · Aug 26, 2021 · ceece5b · ceece5b
1 parent cdfa7f9
commit ceece5b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/main/java/com/nexters/covid/letter/domain/Letter.java b/src/main/java/com/nexters/covid/letter/domain/Letter.java
@@ -96,4 +96,8 @@ public void updateLetterSendOption(SendOption sendOption) {
   public boolean unpostedSendOption() {
     return sendOption.isUnpostedLetter();
   }
+
+  public boolean isFreeQuestion() {
+    return questionId == null;
+  }
 }
diff --git a/src/main/java/com/nexters/covid/letter/service/LetterService.java b/src/main/java/com/nexters/covid/letter/service/LetterService.java
@@ -82,8 +82,11 @@ public LetterResponse findLetterByEncryptedId(String encryptedId) {
     Letter letter = letterRepository.findLetterByEncryptedId(encryptedId)
         .orElseThrow(() -> new IllegalArgumentException("해당 ID의 편지가 없습니다."));
 
-    Question question = questionRepository.findQuestionById(letter.getQuestionId());
+    if (letter.isFreeQuestion()) {
+      return new LetterResponse(letter);
+    }
 
+    Question question = questionRepository.findQuestionById(letter.getQuestionId());
     return new LetterResponse(letter, question);
   }