Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

어드민 로그인 및 회원가입 완료 UI 구현 #11

Merged
merged 4 commits into from
Jan 25, 2024

Conversation

Puterism
Copy link
Member

  • 어드민 로그인 및 회원가입 완료 UI 구현

    • 스크린샷 2024-01-25 오후 8 47 52
    • 스크린샷 2024-01-25
 오후 8 47 15
  • theme 설정 추가 (palette, typo)

  • react-router 6 및 the-new-reset-css 패키지 설정

Copy link

netlify bot commented Jan 25, 2024

Deploy Preview for startling-speculoos-2f9e08 failed.

Name Link
🔨 Latest commit dca9f4d
🔍 Latest deploy log https://app.netlify.com/sites/startling-speculoos-2f9e08/deploys/65b262914f42c10008b69495

Copy link

netlify bot commented Jan 25, 2024

Deploy Preview for extraordinary-piroshki-6a1049 ready!

Name Link
🔨 Latest commit dca9f4d
🔍 Latest deploy log https://app.netlify.com/sites/extraordinary-piroshki-6a1049/deploys/65b26291b8945f00077aa23f
😎 Deploy Preview https://deploy-preview-11--extraordinary-piroshki-6a1049.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 25, 2024

Deploy Preview for loquacious-yeot-37fd34 ready!

Name Link
🔨 Latest commit dca9f4d
🔍 Latest deploy log https://app.netlify.com/sites/loquacious-yeot-37fd34/deploys/65b2629118593600085b2c0d
😎 Deploy Preview https://deploy-preview-11--loquacious-yeot-37fd34.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@alstn2468 alstn2468 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

일단 큰 것은 문제 없어보이니 어푸!
빠르다…! 나도 언넝 작업 들어가볼게!
진행중인 태스크 있으면 아사나 체크 부탁해!

const router = createBrowserRouter([
{
path: '/',
element: <Navigate to="/login" replace />, // Note: 이후 랜딩 페이지로 교체 필요
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

나중에 코드 스플릿팅도 하면 좋겟다!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

나중에 한꺼번에 하자!


const router = createBrowserRouter([
{
path: '/',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

내부 이동할때 편하려면 상수로 각 라우트 정의해도 좋을 것 같아!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋은 아이디어! 작업해둘게

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dca9f4d 에서 작업 완료

const LoginContent = styled.div``;

const Card = styled.div`
width: 600px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rem으로 안써도 괜찮겠지..?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안 써도 된다고 생각함!

@Puterism
Copy link
Member Author

일단 다음 작업 이어서 하셔야 하니까 머지하겠슴둥
netlify build 문제는 추후에 수정하시죵

@Puterism Puterism merged commit 6077548 into main Jan 25, 2024
9 of 13 checks passed
@Puterism Puterism deleted the feature/login-ui branch January 25, 2024 13:33
@Puterism Puterism self-assigned this Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants