-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
어드민 로그인 및 회원가입 완료 UI 구현 #11
Conversation
- react-router 패키지 설정 - the-new-css-reset 패키지 설정
❌ Deploy Preview for startling-speculoos-2f9e08 failed.
|
✅ Deploy Preview for extraordinary-piroshki-6a1049 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for loquacious-yeot-37fd34 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
일단 큰 것은 문제 없어보이니 어푸!
빠르다…! 나도 언넝 작업 들어가볼게!
진행중인 태스크 있으면 아사나 체크 부탁해!
apps/admin/src/App.tsx
Outdated
const router = createBrowserRouter([ | ||
{ | ||
path: '/', | ||
element: <Navigate to="/login" replace />, // Note: 이후 랜딩 페이지로 교체 필요 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
나중에 코드 스플릿팅도 하면 좋겟다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
나중에 한꺼번에 하자!
apps/admin/src/App.tsx
Outdated
|
||
const router = createBrowserRouter([ | ||
{ | ||
path: '/', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
내부 이동할때 편하려면 상수로 각 라우트 정의해도 좋을 것 같아!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
좋은 아이디어! 작업해둘게
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dca9f4d 에서 작업 완료
const LoginContent = styled.div``; | ||
|
||
const Card = styled.div` | ||
width: 600px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rem으로 안써도 괜찮겠지..?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
안 써도 된다고 생각함!
일단 다음 작업 이어서 하셔야 하니까 머지하겠슴둥 |
어드민 로그인 및 회원가입 완료 UI 구현
theme 설정 추가 (palette, typo)
react-router 6 및 the-new-reset-css 패키지 설정