Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/247 [공연상세] 전화/문자로 문의하기 #249

Merged
merged 7 commits into from
May 25, 2024
Merged

Conversation

HamBP
Copy link
Member

@HamBP HamBP commented May 20, 2024

Issue

작업 내용

KakaoTalk_20240520_195629386.mp4

@HamBP HamBP self-assigned this May 20, 2024
@HamBP HamBP added the feat 새로운 기능 label May 20, 2024
@HamBP HamBP added this to the show detail milestone May 20, 2024
Copy link

github-actions bot commented May 20, 2024

Test Results

 7 files   7 suites   0s ⏱️
 7 tests  7 ✅ 0 💤 0 ❌
10 runs  10 ✅ 0 💤 0 ❌

Results for commit 4f44f36.

♻️ This comment has been updated with latest results.

@HamBP HamBP marked this pull request as draft May 20, 2024 15:35
@HamBP HamBP marked this pull request as ready for review May 22, 2024 10:53
Copy link
Member

@mangbaam mangbaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿

val textId = if (isTelephone) R.string.show_call_to_ask else R.string.show_text_to_ask
val context = LocalContext.current

ModalBottomSheet(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[메모]

바텀시트도 스타일 적용한 컴포저블 추출해야겠다 (하라는 거 아님)

.clickable {
val uriKey = if (isTelephone) "tel" else "smsto"
val action = if (isTelephone) Intent.ACTION_DIAL else Intent.ACTION_SENDTO
val intent = Intent(action).setData(Uri.parse("$uriKey:$contact"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@HamBP HamBP merged commit 55a0490 into develop May 25, 2024
2 checks passed
@HamBP HamBP deleted the feature/247 branch July 24, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat 새로운 기능
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[공연상세] 전화/문의하기
2 participants