Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update contribute link across multiple pages #271

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

od-hunter
Copy link

Issue: Close #issue-number

Description

Update the url to the contribute page

editLink: {
    text: "Contribute",
    pattern:
      "https://github.com/NethermindEth/StarknetByExample/edit/vocs/pages/:path",
  },
  • problem:
    This link reference a page with 404 - page not found

    • suggested correctiont:
    editLink: {
      text: "Contribute",
      pattern:
       "https://github.com/NethermindEth/StarknetByExample/blob/dev/CONTRIBUTING.md",
    },
    

@od-hunter
Copy link
Author

od-hunter commented Dec 3, 2024

Logic inaccuracy

Location:

Deploy and interact with contracts / How to deploy

current content:

You should move to the directory where you want to access your account keystores, and then create a new folder for the wallet.

mkdir ./starkli-wallet

Create a new signer. You will be instructed to enter a password to encrypt your private key:

starkli signer keystore new ./starkli-wallet/keystore.json

Problem

following the above generates the following error:
Screenshot from 2024-12-03 06-42-14

suggestion:

Create and move to the directory where you want to access your account keystores, and then create a new folder for the wallet.

mkdir ./starkli-wallet
cd starkli-wallet

Create a new signer. You will be instructed to enter a password to encrypt your private key:

starkli signer keystore new ./keystore.json

@od-hunter
Copy link
Author

@julio4 , can you please review my work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant