Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LDAP dn splitting issue in get-password-policy handlers #41

Merged
merged 1 commit into from
May 2, 2024

Conversation

stephdl
Copy link
Contributor

@stephdl stephdl commented Apr 30, 2024

This PR set ldapsearch to not split the long domain name

refs: NethServer/dev#6910

The fix concern long domain name, the ldapsearch command splits them with \n

[openldap3@R1-pve state]$ ../actions/get-password-policy/50get_password_policy
dn: cn=default,ou=PPolicy,dc=delabrusse,dc=nethvoice-proxy,dc=mv,dc=nethserver
 ,dc=rocky9-pve,dc=org
objectClass: namedPolicy
objectClass: pwdPolicy
objectClass: pwdPolicyChecker
cn: default
pwdAttribute: userPassword
pwdCheckQuality: 2
pwdMinAge: 0
pwdMaxAge: 15552000
pwdMinLength: 8
pwdInHistory: 12
pwdLockout: TRUE
pwdUseCheckModule: TRUE
pwdCheckModuleArg: default
pwdExpireWarning: 0

this is the example of a short domain name

[openldap1@R1-pve state]$ ../actions/get-password-policy/50get_password_policy
dn: cn=default,ou=PPolicy,dc=rocky9-pve,dc=org
objectClass: namedPolicy
objectClass: pwdPolicy
objectClass: pwdPolicyChecker
cn: default
pwdAttribute: userPassword
pwdCheckQuality: 2
pwdMinAge: 0
pwdMaxAge: 15552000
pwdMinLength: 8
pwdInHistory: 12
pwdLockout: TRUE
pwdUseCheckModule: TRUE
pwdCheckModuleArg: default
pwdExpireWarning: 0

@stephdl stephdl requested a review from DavidePrincipi April 30, 2024 12:33
Copy link
Member

@DavidePrincipi DavidePrincipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LLLoL! 🎉

@stephdl stephdl merged commit b368608 into main May 2, 2024
1 check passed
@stephdl stephdl deleted the sdl-6910 branch May 2, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants