Fix relay rule credential handling #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If multiple relay rule records match the host/next-hop search, returned credentials are a mix of them. This commit ensures that only a couple username/password is properly returned, randomly choosen between the matching ones.
If a rule has authentication enabled, display the user name in Authenticated column.
If a wildcard rule or a recipient rule is present, clarify that settings are attributes of the host, not the recipient: this is the Postfix behavior.
As Postfix requires, relay rules with type non-sender must share the same authentication and TLS settings for a given host:port key. This commit ensures that settings are propagated to existing rules with a matching host:port combination.
Just to remember the standard SMTP port numbers.
andre8244
reviewed
Nov 20, 2024
stephdl
approved these changes
Nov 20, 2024
Prefer computed variable implementation.
andre8244
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix proposal for NethServer/dev#7069
Overview
This pull request introduces a series of fixes and improvements to the Postfix relay configuration and its user interface:
Fix mangled credentials in Postfix relay rules:
LIMIT 1clause has been added to the query to address this issue.Display username in the Relay table:
Add notice about shared settings:
Enforce shared host settings for relay rules:
Changes
Backend:
Frontend:
Motivation
These changes resolve issues related to inconsistent relay rule settings and enhance the user experience by improving clarity and functionality in both the backend and UI. They align with Postfix's requirements and simplify relay rule management.
Related Issues
UI preview