Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix basic test to dokuwiki #21

Merged
merged 4 commits into from
Mar 13, 2024
Merged

Fix basic test to dokuwiki #21

merged 4 commits into from
Mar 13, 2024

Conversation

stephdl
Copy link
Contributor

@stephdl stephdl commented Mar 13, 2024

The basic github action of dokuwiki needs to be fixed, we try to test on a ubuntu container

@@ -8,4 +8,5 @@ permissions:

jobs:
publish-images:
if: github.run_number > 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was set like that in webtop, not searched a lot for it

https://github.com/NethServer/ns8-webtop/blob/4452c66c531f233e1b3fcc08411d6242b6ddc3c1/.github/workflows/publish-images.yml#L11

What do you think

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That if is present in the ns8-webtop repository because it was created from the ns8-kickstarter, there is no need to use it now.

.github/workflows/publish-images.yml Outdated Show resolved Hide resolved
@stephdl stephdl merged commit 10b3845 into main Mar 13, 2024
1 check passed
@stephdl stephdl deleted the CiCd branch March 13, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants