webmin: Split up index page into three tabs #1785
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdmark
force-pushed
the
1761-webmin-move-home-dir-and-presets-tables-into-separate-pages
branch
from
fd86b1d to
6e9ac09
Compare
|
For the record, I'm holding off on merging this until 4.0 is finally branched off and we start work on 4.1. This change is too drastic for a bugfix release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than a monolithic index page for the webmin module, this introduces a tabbed UI with three tabs: One for the AFP file server (the default), one for DDP (AppleTalk) services, and one for other global settings.
This brings two benefits: Better at-a-glance understanding of the state of the AFP file server when you enter the module, which is what most people are interested in. And secondly, more logical grouping of settings and service control.
The main drawback is that operations on secondary tabs gives you a roundtrip to the default tab, which can be a chore especially when starting/stopping the AppleTalk services.