Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(babel-preset-taro): 配置中使用了不正确的插件 #16726

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Oct 17, 2024

这个 PR 做了什么? (简要描述所做更改)

更新 babel 使用的插件名称

@babel/plugin-proposal-class-properties 插件已弃用,应采用 @babel/plugin-transform-class-properties

注意到 package.json 中已更新使用新插件,但 index.js 中尚未更新使用新插件

查看提交记录注意到对应插件已在 2ca1ce59c49d7900f6a098165299c2c52ea0548d 提交中更新为新插件,但在 c7688632f566016465e257756707acafbac604a6 中意外地恢复为弃用的原插件(但未恢复 package.json 中的)

在合并该 PR 后,就可以回退 5400d1f4bd538bdb5e022e0a3abccb92f1483826,从项目模板中移除该弃用的插件,参见 #16727

Note

考虑到该插件已被包含在 @babel/preset-env 中,未来可以考虑移除该插件

同时参见文档更新 NervJS/taro-docs#284

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue: fix #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他,请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • 移动端(React-Native)
  • 鸿蒙(harmony)

@skyclouds2001 skyclouds2001 changed the title fix: babel plugin incorrect usage bug fix(babel-preset-taro): 不正确的插件使用 Oct 17, 2024
@skyclouds2001 skyclouds2001 changed the title fix(babel-preset-taro): 不正确的插件使用 fix(babel-preset-taro): 配置中使用了不正确的插件 Oct 17, 2024
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.52%. Comparing base (c17123d) to head (7e0b101).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #16726   +/-   ##
=======================================
  Coverage   58.52%   58.52%           
=======================================
  Files         466      466           
  Lines       27099    27099           
  Branches     5908     5933   +25     
=======================================
  Hits        15860    15860           
- Misses       9895     9924   +29     
+ Partials     1344     1315   -29     
Flag Coverage Δ
taro-cli 73.67% <ø> (ø)
taro-runtime 59.87% <ø> (ø)
taro-web 52.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/babel-preset-taro/index.js 73.03% <ø> (ø)

... and 12 files with indirect coverage changes

@ZEJIA-LIU ZEJIA-LIU requested a review from zhengyanan1 October 22, 2024 02:57
@ZEJIA-LIU ZEJIA-LIU modified the milestone: 4.0.7 Oct 22, 2024
This was referenced Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants