Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make compatible to AA 0.43.0 #1849

Merged
merged 4 commits into from
Sep 18, 2024
Merged

Make compatible to AA 0.43.0 #1849

merged 4 commits into from
Sep 18, 2024

Conversation

lgoettgens
Copy link
Collaborator

No description provided.

lgoettgens
lgoettgens commented Sep 18, 2024
View reviewed changes
Project.toml Outdated Show resolved Hide resolved
lgoettgens
lgoettgens commented Sep 18, 2024
View reviewed changes
src/flint/nmod.jl Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Sep 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.62500% with 3 lines in your changes missing coverage. Please review.

Project coverage is 86.21%. Comparing base (18dfcb9) to head (0d75048).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/flint/fmpz_laurent_series.jl 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1849      +/-   ##
==========================================
+ Coverage   86.19%   86.21%   +0.01%     
==========================================
  Files          99       99              
  Lines       36274    36031     -243     
==========================================
- Hits        31268    31065     -203     
+ Misses       5006     4966      -40

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thofma
Copy link
Member

thofma commented Sep 18, 2024

We also need #1759

@lgoettgens
Copy link
Collaborator Author

We also need #1759

Yeah, but only after this is green.

@lgoettgens lgoettgens force-pushed the lg/AA-compat branch 2 times, most recently from d509853 to 84c1142 Compare September 18, 2024 14:15
@lgoettgens lgoettgens marked this pull request as ready for review September 18, 2024 14:37
@lgoettgens lgoettgens mentioned this pull request Sep 18, 2024
Merged
2 tasks
@lgoettgens lgoettgens requested a review from thofma September 18, 2024 14:40
@thofma thofma merged commit 6442041 into master Sep 18, 2024
25 checks passed
@thofma thofma deleted the lg/AA-compat branch September 18, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thofma thofma thofma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lgoettgens @thofma @joschmitt