Misc staging fixes. #4686
Misc staging fixes. #4686
Conversation
MistakeNot4892
commented
Dec 29, 2024
MistakeNot4892
commented
- Fixes Prosthetic Wooden Hands Cannot Open Doors ScavStation/ScavStation#1160.
- Attempts to mitigate the worst of Janibot does not automop floors #4684 (not necessarily successfully).
- Simplifies AI attack windups.
- Allows ingested items to melt (mostly for people eating water cubes or nutriment scraps).
MistakeNot4892
force-pushed
the
fixes/staging
branch
from
ffd2483 to
674f8d9
Compare
| var/static/list/_melting_containers = list( | ||
| /obj/item/chems/crucible, | ||
| /obj/item/organ/internal/stomach | ||
| ) | ||
| if(!is_type_in_list(loc, _melting_containers)) | ||
| return |
There was a problem hiding this comment.
i would ideally like for this to use a typecache, since it's marginally faster if we ever add more types to this, but it should be fine for now
There was a problem hiding this comment.
Seems like overkill for what amounts to a temporary workaround to be honest.
There was a problem hiding this comment.
yeah fair enough, like I said, fine for now
| if(S.material?.type == /decl/material/solid/metal/steel) | ||
| return (amount < maxAmount && maketiles) | ||
|
|
||
| if(A.loc.name == "Space") | ||
| if(target.loc.name == "Space") |
There was a problem hiding this comment.
WHAT.
this should probably be is_open() or whatever rather than... that. christ. oh god. how many other cases of this are there?
| @@ -10,7 +10,7 @@ | |||
| icon_base = 'icons/mob/human_races/cyberlimbs/morgan/morgan_main.dmi' | |||
| modifier_string = "wooden" | |||
| hardiness = 0.75 | |||
| manual_dexterity = DEXTERITY_SIMPLE_MACHINES | |||
| manual_dexterity = DEXTERITY_SIMPLE_MACHINES | DEXTERITY_HOLD_ITEM | DEXTERITY_EQUIP_ITEM | DEXTERITY_KEYBOARDS | DEXTERITY_GRAPPLE | |||
There was a problem hiding this comment.
i don't know how to feel about that. what does this even prevent you from doing, now? it kind of feels like we're making wooden limbs not actually much worse than modern prostheses, especially given that DEXTERITY_COMPLEX_TOOLS or whatever isn't really used much on shaded hills. maybe we should just make bumping airlocks not check dexterity if it's worn and not held? and to open structure doors, we could make it so that it just needs DEXTERITY_HOLD_ITEM.
alternatively i'm open to hearing why wooden prostheses should have all of these? but I kind of liked the niche they had before.
There was a problem hiding this comment.
Not being able to hold and equip items makes them worse than mouth slots. They are almost completely pointless. Keyboards seems like an oversight, you can peck type with a hook. Grapple I'm ambivalent about, put it on there because you need it to drag.
Not being able to use complex electronics or weapons makes them still notably different/worse than regular prosthetics imo.
There was a problem hiding this comment.
I could override them on Shaded Hills but they are really crap to use at the moment.
There was a problem hiding this comment.
sure, I'll take that. the name == "Space" thing should still go though, otherwise that's the only change requested
There was a problem hiding this comment.
Yeah I just pushed a fix for that.
There was a problem hiding this comment.
As a case in point for how useless they are, you cannot currently remove your headset with a prosthetic wooden hand. Would like to just buff them overall to be honest.
MistakeNot4892
force-pushed
the
fixes/staging
branch
from
674f8d9 to
4aaf094
Compare
MistakeNot4892
force-pushed
the
fixes/staging
branch
from
4aaf094 to
e6bc444
Compare
