-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Barrel/well interaction rework. #4660
Open
MistakeNot4892
wants to merge
6
commits into
NebulaSS13:dev
Choose a base branch
from
MistakeNot4892:rework/barrels
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+467
−293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MistakeNot4892
added
the
work in progress
This PR is under development and shouldn't be merged.
label
Dec 20, 2024
Something has broken in the fill/pour interactions and now they aren't showing up on barrels. Augh. Issue for tomorrow. |
MistakeNot4892
force-pushed
the
rework/barrels
branch
from
December 21, 2024 05:19
34a1b0b
to
c902464
Compare
MistakeNot4892
added
ready for review
This PR is ready for review and merge.
and removed
work in progress
This PR is under development and shouldn't be merged.
labels
Dec 21, 2024
MistakeNot4892
force-pushed
the
rework/barrels
branch
from
December 28, 2024 23:03
c902464
to
bc7a147
Compare
DNM, need to check if this has clobbered hammer deconstruction. |
…st for wells and barrels.
MistakeNot4892
force-pushed
the
rework/barrels
branch
from
January 1, 2025 10:59
bc7a147
to
ec813f9
Compare
Ready to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Really not sure about the implementation of this one. Going to pull it into Pyrelight volatile for testing over the weekend.
get_standard_interactions()
and calls it similarly to alt interactions at the root ofattackby()
andattack_hand()
.Why and what will this PR improve
We are at a point where the UX for some structures is getting stupid. Barrels and wells are the most obvious/severe example: if you have a half full bucket, and a half full well, and you click the bucket on the well, the interaction has to be mediated by flag checks and a toggle on the well atom, or workarounds like drag-drop.
This puts support in place for similar interactions in the future, and solves the immediate barrel/well issues.
Authorship
Myself.
Changelog
🆑
tweak: The way you interact with barrels and well has been significantly reworked; clicking with a bucket or tool should give a list of options to pick from. Please report bugs with this on the tracker.
/:cl: