Fix Google Drive download and specify opencv version #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Force opencv-python package versions to be the ones that were current when the original requirements.txt was uploaded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In trying to set up the repository to recreate the World Consistent Video2Video, I hit two errors that I have fixed in this PR.
The Google Drive download protocol used in
io.pyno longer works due to a change in how Google Drive handles requests. The currentio.pywill cause all downloads to silently fail because it will download a Google Drive HTML warning. The original logic appears to be similar to that of this StackOverflow post and so I adapted the last comment so that it uses aPOSTrequest including the&confirm=tparameter. This can be verified by trying to download one of the models. Swapping to a library may be preferred for long-term support.Separately, the installation with Docker would not run due to an error on
import cv2. This appears to due to a change inopencv-pythonsincerequirements.txtwas uploaded. This fixes that error by forcing all of theopencv-pythondependencies to version4.5.4.58which was the current version as of Nov 12, 2021 whenrequirements.txtwas originally committed. I do not know that this is the correct version, but it resulted in a working build for me.