Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: drm/prime: support dmabuf mmap #355

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

YusufKhan-gamedev
Copy link

Not sure if its 'prime' or 'PRIME'

Signed-off-by: Yusuf Khan [email protected]

Not sure if its 'prime' or 'PRIME'

Signed-off-by: Yusuf Khan <[email protected]>
@YusufKhan-gamedev YusufKhan-gamedev changed the title drm/prime: support dmabuf mmap WIP: drm/prime: support dmabuf mmap Aug 27, 2022
Copy link
Collaborator

@mtijanic mtijanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I won't look too closely while it still has the WIP tag, but I'm curious, what are some particular usecases you are targeting with this change?

And related, what would be good ways to test and validate the change?

@@ -826,7 +826,9 @@ static struct drm_driver nv_drm_driver = {
.gem_prime_get_sg_table = nv_drm_gem_prime_get_sg_table,
.gem_prime_vmap = nv_drm_gem_prime_vmap,
.gem_prime_vunmap = nv_drm_gem_prime_vunmap,

#if LINUX_VERSION_CODE >= KERNEL_VERSION(5, 0, 0)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this still says WIP, but take a look at this related conftest instead of kernel version check:
https://github.com/NVIDIA/open-gpu-kernel-modules/blob/main/kernel-open/conftest.sh#L4342-L4364

@YusufKhan-gamedev
Copy link
Author

The usecase is for whenever a user wants to convert a GEM handle to a dmabuf handle and then mmap it. I couldnt get a example working on my RADEON laptop hence why this is marked WIP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants