Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues reported by verification scripts #22

Merged
merged 1 commit into from
May 10, 2024

Conversation

yuanchen8911
Copy link
Collaborator

@yuanchen8911 yuanchen8911 commented May 10, 2024

This PR addresses the following issues reported by verification scripts (spelling, gofmt, and golint) in the current code and documentation:

  1. Go import package order, e.g., knavigator packages should be at the end.
  2. Typos.

@yuanchen8911 yuanchen8911 requested review from dmitsh and shinae-woo May 10, 2024 01:16
Copy link
Collaborator

@dmitsh dmitsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Golang, it is customary to organize import statements into groups:

Standard library packages
Third-party packages
Internal packages of the current project

Signed-off-by: Yuan Chen <[email protected]>
@yuanchen8911
Copy link
Collaborator Author

In Golang, it is customary to organize import statements into groups:

Standard library packages Third-party packages Internal packages of the current project

That's my understanding too. Those changes were automatically generated by the script. It's stragne. I've reverted all the changes except the format one.

@yuanchen8911 yuanchen8911 requested a review from dmitsh May 10, 2024 15:32
@yuanchen8911 yuanchen8911 merged commit 24ced76 into NVIDIA:main May 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants