-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add verify scripts for various checks #21
Conversation
isn't it an overkill? |
I removed the directory I think these scripts are quite useful. Running @dmitsh, can you take another look? |
70d7ef7
to
2a6aa78
Compare
/retest |
eb9ecf3
to
6aca469
Compare
3829ea8
to
a56ecc4
Compare
48a3a9c
to
7ca2fcc
Compare
7ca2fcc
to
9dff93a
Compare
I have one issue on yaml format, which I can ignore.
And two new lines at end of file
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than issues I reported on above comments
Thanks! Not sure how to fix the first one. #28 should fix the empty line issues. |
Signed-off-by: Yuan Chen <[email protected]> Add verify and update to Makefile Signed-off-by: Yuan Chen <[email protected]> Remove venv Revert changes Signed-off-by: Yuan Chen <[email protected]> Add yamlfmt Signed-off-by: Yuan Chen <[email protected]> Remove golangci.yaml Fix goling config file names
9dff93a
to
66ea4c8
Compare
This reverts commit 144e7a7, reversing changes made to 2f29e50. Signed-off-by: Yuan Chen <[email protected]>
Add verification and check scripts: gofmt, golint, spelling check, yaml format, ...
hack/verifiy-all
ormake verify
will perform all checks.hack/update-all
ormake update
will correct all the issues.