Add git workflow for golang linters and unittests #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shinae-woo
force-pushed
the
git-workflow-linter
branch
2 times, most recently
from
ae67c9f to
b628693
Compare
Signed-off-by: Shinae Woo <[email protected]>
Signed-off-by: Shinae Woo <[email protected]>
shinae-woo
force-pushed
the
git-workflow-linter
branch
from
b628693 to
29b9a9d
Compare
dmitsh
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This workflow will be triggered on every push event on the main and when creating or updating new PRs.
go vetmight be redundant with golangci-lint as well. But I included it as a part of workflow as Makefile has a separate target for itWe may also need to introduce golangci config as well.