[no-relnote] Only trigger signing jobs on tags #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evan Lezar <[email protected]>
cdesiniotis
requested changes
Jul 17, 2024
| IMAGE_TAG: "${SIGN_JOB_NAME}${CI_COMMIT_TAG}" | ||
| - when: always | ||
| IMAGE_TAG: "${CI_COMMIT_TAG}" | ||
| - if: $CI_COMMIT_TAG |
There was a problem hiding this comment.
Note, we have a duplicate if: $CI_COMMIT_TAG conditional in the .sign:ngc template. We need to make sure this is defined only once.
There was a problem hiding this comment.
Could you clarify what you mean by "this" here? It is my understanding that rules in gitlab CI are evaluated top to bottom and triggered on the first match. Rules that follow are not evaluated.
There was a problem hiding this comment.
Are the rules defined in sign:ngc evaluated before the rules defined in .sign:ngc? If that is the case then we can resolve this comment.
There was a problem hiding this comment.
If we define rules here, these override the rules in the base definition. We are NOT extending the rules but replacing them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.