Add --no-cleanup-on-exit option to GFD #899
Open
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elezar
force-pushed
the
add-no-cleanup-on-exit-GFD-option
branch
from
adc2c82 to
e64fb90
Compare
This change adds a --no-cleanup-on-exit option to GFD that skips the removal of the generated labels file. Signed-off-by: Evan Lezar <[email protected]>
elezar
force-pushed
the
add-no-cleanup-on-exit-GFD-option
branch
from
e64fb90 to
08363f4
Compare
|
@elezar, are there any updates or issues related to this fix? We are still eagerly awaiting its inclusion in the next release. One thing: as was rightly noted in comment #796 (comment), when using the NodeFeature API, such automatic cleanup does not occur. Considering this, such a general option name as |
|
This PR is stale because it has been open 90 days with no activity. This PR will be closed in 30 days unless new comments are made or the stale label is removed. |
github-actions
bot
added
the
lifecycle/stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a --no-cleanup-on-exit option to GFD that skips the removal of the generated labels file.
See #796