Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename --save-temps option to -save-temps. #2294

Merged
merged 3 commits into from
Oct 18, 2024
Merged

Rename --save-temps option to -save-temps. #2294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
921dc38
Rename --save-temps option to -save-temps.
schweitzpgi Oct 17, 2024
04a3062
Allow --save-temps as well since clang likes that spelling.
schweitzpgi Oct 18, 2024
797fdcf
Merge branch 'main' into ch-forigi.plurecon
schweitzpgi Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/sphinx/using/extending/cudaq_ir.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ Let's see the output of :code:`nvq++` in verbose mode. Consider a simple code li

.. code-block:: console

$ nvq++ simple.cpp -v --save-temps
$ nvq++ simple.cpp -v -save-temps

cudaq-quake --emit-llvm-file simple.cpp -o simple.qke
cudaq-opt --pass-pipeline=builtin.module(canonicalize,lambda-lifting,canonicalize,apply-op-specialization,kernel-execution,indirect-to-direct-calls,inline,func.func(quake-add-metadata),device-code-loader{use-quake=1},expand-measurements,func.func(lower-to-cfg),canonicalize,cse) simple.qke -o simple.qke.LpsXpu
Expand All @@ -39,7 +39,7 @@ This workflow orchestration is represented in the figure below:
.. image:: ../../_static/nvqpp_workflow.png

We start by mapping CUDA-Q C++ kernel representations (structs, lambdas, and free functions)
to the Quake dialect. Since we added :code:`--save-temps`,
to the Quake dialect. Since we added :code:`-save-temps`,
we can look at the IR code that was produced. The base Quake file, :code:`simple.qke`, contains the following:

.. code-block:: console
Expand Down
4 changes: 2 additions & 2 deletions tools/nvqpp/nvq++.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ function show_help {
--opt-pass <pass name>
Append a pass to the pass pipeline by specifying its name in the pass pipeline syntax, e.g. <dialect>.<opname>(passname).

--save-temps
-save-temps
schweitzpgi marked this conversation as resolved.
Show resolved Hide resolved
Save temporary files.

-o=<obj>
Expand Down Expand Up @@ -520,7 +520,7 @@ while [ $# -ne 0 ]; do
CUDAQ_OPT_EXTRA_PASSES=$(add_pass_to_pipeline "${CUDAQ_OPT_EXTRA_PASSES}" "$2")
shift
;;
--save-temps)
-save-temps|--save-temps)
DELETE_TEMPS=false
;;
-h|--help)
Expand Down
Loading