Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Python/C++ interop via exposed JIT functionality #2214

Merged
merged 17 commits into from
Oct 17, 2024

Conversation

amccaskey
Copy link
Collaborator

@amccaskey amccaskey commented Sep 17, 2024

Enable one to pass Python kernels to library entry-point kernels defined in C++. Enable one to expose C++ pure-device kernels to Python.

Copy link

copy-pr-bot bot commented Sep 17, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@amccaskey
Copy link
Collaborator Author

amccaskey commented Oct 7, 2024

/ok to test

Command Bot: Processing...

Copy link

github-actions bot commented Oct 7, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Oct 7, 2024
@khalatepradnya
Copy link
Collaborator

khalatepradnya commented Oct 8, 2024

/ok to test

Command Bot: Processing...

Copy link

github-actions bot commented Oct 8, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Oct 8, 2024
@amccaskey
Copy link
Collaborator Author

amccaskey commented Oct 14, 2024

/ok to test

Command Bot: Processing...

1 similar comment
@amccaskey
Copy link
Collaborator Author

amccaskey commented Oct 15, 2024

/ok to test

Command Bot: Processing...

@amccaskey amccaskey requested a review from bmhowe23 October 15, 2024 12:24
include/cudaq/Optimizer/Transforms/Passes.h Outdated Show resolved Hide resolved
lib/Optimizer/Transforms/PySynthCallableBlockArgs.cpp Outdated Show resolved Hide resolved
lib/Optimizer/Transforms/PySynthCallableBlockArgs.cpp Outdated Show resolved Hide resolved
lib/Optimizer/Transforms/PySynthCallableBlockArgs.cpp Outdated Show resolved Hide resolved
python/CMakeLists.txt Outdated Show resolved Hide resolved
python/runtime/interop/PythonCppInterop.cpp Outdated Show resolved Hide resolved
@amccaskey
Copy link
Collaborator Author

amccaskey commented Oct 16, 2024

/ok to test

Command Bot: Processing...

Copy link
Collaborator

@schweitzpgi schweitzpgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the updates.

lib/Optimizer/Transforms/PySynthCallableBlockArgs.cpp Outdated Show resolved Hide resolved
Signed-off-by: Alex McCaskey <[email protected]>
@amccaskey
Copy link
Collaborator Author

amccaskey commented Oct 16, 2024

/ok to test

Command Bot: Processing...

@amccaskey
Copy link
Collaborator Author

amccaskey commented Oct 16, 2024

/ok to test

Command Bot: Processing...

@amccaskey
Copy link
Collaborator Author

amccaskey commented Oct 17, 2024

/ok to test

Command Bot: Processing...

@amccaskey amccaskey enabled auto-merge (squash) October 17, 2024 12:43
@amccaskey amccaskey merged commit 8bc1349 into NVIDIA:main Oct 17, 2024
132 checks passed
sacpis pushed a commit to sacpis/cuda-quantum that referenced this pull request Oct 17, 2024
* Enable C++ interop with user Python kernels.

Signed-off-by: Alex McCaskey <[email protected]>
copy-pr-bot bot pushed a commit that referenced this pull request Oct 17, 2024
* Enable C++ interop with user Python kernels.

Signed-off-by: Alex McCaskey <[email protected]>
Signed-off-by: Anna Gringauze <[email protected]>
@bettinaheim bettinaheim added the release notes Changes need to be captured in the release notes label Nov 19, 2024
@bettinaheim bettinaheim added this to the release 0.9.0 milestone Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes Changes need to be captured in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants