Bind the new_fwd method to the model during amp.initialize #1235
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any update on this? I'm hoping to have this reviewed so we can avoid using workarounds in user code. |
|
Hello, wanted to follow up to see if this can be reviewed or looked at? |
|
Hi @baijumeswani, Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During
amp.initialize(), the patched forward is directly assigned to the model without binding it usingMethodType.This resulted in an error while trying to access the
__func__attribute of the forward method of the model.AttributeError: 'function' object has no attribute '__func__'Minor change in this pull request just binds the patched forward method to the model.