No need to build tensorflow-text from source: py3.12 x86/arm64 wheels are available on pypi #1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DwarKapex
requested review from
yhtang,
gspschmid,
olupton,
CliveUnger and
terrykong
nouiz
reviewed
Dec 20, 2024
| @@ -86,5 +45,5 @@ RUN pip-finalize.sh | |||
|
|
|||
| WORKDIR ${SRC_PATH_MAXTEXT} | |||
|
|
|||
| # When tftext and lingvo wheels are published on pypi.org, revert this | |||
| # When tftext wheels are published on pypi.org, revert this | |||
| # Dockerfile to 5c4b687b918e6569bca43758c346ad8e67460154 | |||
There was a problem hiding this comment.
Remove both lines and do that revert?
There was a problem hiding this comment.
I cannot do that now: the commit mentioned here assumes that both tftext and lingvo are available on python-3.12, but it's not true for lingvo, that's why we still need to build lingvo for both x86_64 and arm64.
|
|
||
| # Preserve version information of tensorflow-text and lingvo | ||
| COPY --from=lingvo-builder /opt/manifest.d/git-clone.yaml /opt/manifest.d/git-clone.yaml | ||
| COPY --from=lingvo-builder /tmp/lingvo/dist/lingvo*-linux*.whl /opt/ | ||
| RUN echo "lingvo @ file://$(ls /opt/lingvo*.whl)" >> /opt/pip-tools.d/requirements-paxml.in | ||
|
|
||
| COPY --from=tftext-builder ${SRC_PATH_TFTEXT}/tensorflow_text*.whl /opt/ | ||
| RUN echo "tensorflow-text @ file://$(ls /opt/tensorflow_text*.whl)" >> /opt/pip-tools.d/requirements-paxml.in | ||
|
|
||
| # paxml + praxis | ||
| RUN <<"EOF" bash -ex | ||
| echo "tensorflow_datasets==4.9.2" >> /opt/pip-tools.d/requirements-paxml.in |
There was a problem hiding this comment.
Updates the last 2 lines of this file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, Google has released tensorflow-text 2.18.1 that is available on python-3.12 and both archs: x86 and arm64. So, we don't need to build it from source any more