-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nsys-jax: optimise data loading and .zip creation #1193
Open
olupton
wants to merge
12
commits into
main
Choose a base branch
from
olupton/nsys-jax-python-opt
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olupton
force-pushed
the
olupton/nsys-jax-python-opt
branch
2 times, most recently
from
December 10, 2024 11:28
4f1b629
to
608e45c
Compare
…ax Python code clearer
olupton
force-pushed
the
olupton/nsys-jax-python-opt
branch
from
December 10, 2024 14:10
608e45c
to
385c7f4
Compare
…n profiles clearer
Plumb through `prefix` so it's more convenient to explicitly set the input data path.
olupton
force-pushed
the
olupton/nsys-jax-python-opt
branch
2 times, most recently
from
December 10, 2024 15:43
f3189d1
to
74a3d94
Compare
…v with Python's lzma.
olupton
force-pushed
the
olupton/nsys-jax-python-opt
branch
from
December 10, 2024 15:58
74a3d94
to
d8056e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some rough measurements on vanilla
jax-nccl-test
and 8xH100:The differences are more pronounced on larger workloads with more activity.
The two bigger changes are:
.csv
to.parquet
as part ofnsys-jax
to avoid compressing.csv
with Python'slzma
module, which is slow and single-threaded. This speeds upnsys-jax
and subsequent data-loading.Otherwise there are some tweaks to pandas usage and minor reorganisations to make Python profiles more informative, and minor bugfixes in the example Jupyter notebook.