Address SAM issue 1184 #1055
Merged
Address SAM issue 1184 #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjprilliman
approved these changes
Sep 22, 2023
| @@ -64,8 +64,8 @@ | |||
| "subarray1_nmody" : 2, | |||
| "subarray1_backtrack" : 0, | |||
| "subarray2_enable" : 0, | |||
| "subarray2_modules_per_string" : 0, | |||
| "subarray2_nstrings" : 0, | |||
| "subarray2_modules_per_string" : 1, | |||
There was a problem hiding this comment.
Is this going to effect default requirements as well? I.E. will subarray2_modules_per_string have to be set to 1 rather than 0 on case load even though subarray 2 is not enabled? Right now the default Detailed PV cases will fail with subarray 2-4 nstrings and modules_per_string set to 0. Guess it's a logical next step to update those defaults to allow SAM to still run when another subarray is added without extra steps.
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.