Remove old cmods #1054
Merged
Remove old cmods #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dguittet
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes old/unused compute modules
poacalib,pvwattsv0,pvwattsv1,pvwattsv1_1ts, andpvwattsv1_poa. These versions of pvwatts have not been used by the main SAM project or PVWatts websites in many years. They are still available in the code attic, but NREL will no longer be updating them to work with updates made to the libraries used in those files.I believe I removed them in all the appropriate places, and they were not in any of the SAM or PySAM api files to begin with, but would appreciate a review of that.