Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compression options for GEFS history files #3184

Merged

Conversation

CatherineThomas-NOAA
Copy link
Contributor

Description

Different compression options are applied for the high resolution history files. The value of quantize_nsd will be different depending on the value of quantize_mode, so a fix is required to obtain the same behavior as the previous compression options. This option needs to be updated for both GFS and GEFS.

Resolves: #3178

Type of change

  • Bug fix (fixes something broken)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO

How has this been tested?

The change of quantize_nsd from 5 to 14 was tested for the GFS at C384. See #3129 for details. This change was NOT tested in the GEFS.

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

Different compression options are applied for the high resolution
history files. The value of quantize_nsd will be different
depending on the value of quantize_mode, so a fix is required
to obtain the same behavior as the previous compression options.
This option needs to be updated for both GFS and GEFS.

Resolves: NOAA-EMC#3178
@CatherineThomas-NOAA
Copy link
Contributor Author

Pinging @bingfu-NOAA, noting that I have not tested this change within the GEFS. I would not expect the parameter to behave differently between the two systems, but just making sure that you are aware in case you want to run any of your own tests.

@aerorahul aerorahul merged commit 2007864 into NOAA-EMC:develop Dec 20, 2024
5 checks passed
@bingfu-NOAA
Copy link
Contributor

@CatherineThomas-NOAA thanks for letting me know. We haven't tested that, will keep that in mind.

DavidHuber-NOAA added a commit to DavidHuber-NOAA/global-workflow that referenced this pull request Dec 20, 2024
* emc/develop:
  Change orog gravity wave drag scheme for grid sizes less than 10km (NOAA-EMC#3175)
  Switch snow DA to use 2DVar for deterministic and ensemble mean (NOAA-EMC#3163)
  Update compression options for GEFS history files (NOAA-EMC#3184)
tsga added a commit to tsga/global-workflow that referenced this pull request Dec 22, 2024
* feature/land_iau:
  modify for Clara's gauss-fv3 regridding
  Change orog gravity wave drag scheme for grid sizes less than 10km (NOAA-EMC#3175)
  Switch snow DA to use 2DVar for deterministic and ensemble mean (NOAA-EMC#3163)
  Update compression options for GEFS history files (NOAA-EMC#3184)
@CatherineThomas-NOAA CatherineThomas-NOAA deleted the bugfix/quantize_gefs branch January 2, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants