-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set runtime shell requirements within Jenkins Pipeline #3171
base: develop
Are you sure you want to change the base?
Set runtime shell requirements within Jenkins Pipeline #3171
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have added HOMEGFS to the runtime shell environment for gaea C5/C6 both in our epic role account .bashrc file as follows:
Added for Global Workflow
if [ -n "${HOMEGFS+x}" ] && [ -n "${HOMEGFS}" ]; then
source ${HOMEGFS}/workflow/gw_setup.sh
fi
@AnilKumar-NOAA Oh I see now that you were referring to the |
Checkout Failed on Orion in Build# 6: Could not perform submodule update |
e433ced
to
1c37f90
Compare
… a shell call to the node
CI Passed on Orion in Build# 1
|
… experment which should be its sole purpose, also did a which on gh incase it is not in ~/bin
export GH="${HOME}/bin/gh" | ||
[[ -f "${GH}" ]] || echo "gh is not installed in ${HOME}/bin" | ||
GH=$(command -v gh || echo "${HOME}/bin/gh") | ||
[[ -f "${GH}" ]] || echo "ERROR: GitHub CLI (gh) not found. (exiting with error)"; exit 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is what I think you intend. Otherwise, exit 1
will be called regardless of the result.
[[ -f "${GH}" ]] || echo "ERROR: GitHub CLI (gh) not found. (exiting with error)"; exit 1 | |
[[ -f "${GH}" ]] || ( echo "ERROR: GitHub CLI (gh) not found. (exiting with error)"; exit 1 ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes to source gw_setup.sh
are good.
A comment at the end of this PR re. GH
might solve the shellnorm error. Please check.
Approve.
Description
This PR updates the Jenkins Pipeline script to source
gw_setup.sh
from within the PR itself for when ever a shell command is issued that needs it.Currently the runtime bash shell environment requirements for running the global-workflow (set by sourcing
$HOMEgfs/workflow/gw_setup.sh
) is established by the user's shell that makes the connection from the Java remote agent to the Jenkins Controller. This update simply sourcesgw_setup.sh
directly during run time when ever needed instead.NOTE: This does not apply for GitHub CLI and pyGitHub since they are not currently supported by Spack Stack and therefore not incorporated in to
gw_setup.sh
. These remaining dependances are the responsibility of the role account holders that manage the Jenkins Controller to Node Agent connections.Type of change