Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ufs-weather-model to 2024-12-06 commit #3145

Merged
merged 11 commits into from
Dec 14, 2024
Merged

Update ufs-weather-model to 2024-12-06 commit #3145

merged 11 commits into from
Dec 14, 2024

Conversation

JessicaMeixner-NOAA
Copy link
Contributor

@JessicaMeixner-NOAA JessicaMeixner-NOAA commented Dec 6, 2024 •
edited
Loading

Description

This PR updates ufs-weather-model hash to the latest commit which addresses an issue seen in an earlier commit (see: #3110)

Note this includes the PR that enables PIO for WW3, however additional work is required to use this feature.
Another notable PR update is for a PIO finalize bug in CICE which also required updates to ice_in

Fixes #3110

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO (If YES, please add a link to any PRs that are pending.)
    • EMC verif-global
    • GDAS
    • GFS-utils
    • GSI
    • GSI-monitor
    • GSI-utils
    • UFS-utils
    • UFS-weather-model
    • wxflow

How has this been tested?

Quick test that forecast runs for S2SW GFS. Running a quick cycled test but wanted to share this now so others don't have to make the same updates here in their local branches.

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

aerorahul
aerorahul previously approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks straight-forward.

DavidHuber-NOAA
DavidHuber-NOAA previously approved these changes Dec 9, 2024
View reviewed changes
@DavidHuber-NOAA DavidHuber-NOAA added the CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules label Dec 9, 2024
@emcbot emcbot added CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress and removed CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules labels Dec 9, 2024
@JessicaMeixner-NOAA
Copy link
Contributor Author

Sorry I just was checking some tests I ran over the weekend for the WCDA - and I found an issue so we might want to stop the CI as I'm assuming itll find the same issue!

For the WCDA test:

The log file is here:
/scratch1/NCEPDEV/climate/Jessica.Meixner/gwprupdateufs/twcda01/COMROOT/twcda01/logs/2021032412/gdas_fcst_seg0.log.0 and we get an error:

20:
20:  (abort_ice)ABORTED:
20:  (abort_ice) error =
20:  (construct_filename) ERROR: history filename already used for another history s
20:  tream iceh_inst.2021-03-24-43200.nc

The ice_in file is here: /scratch1/NCEPDEV/stmp2/Jessica.Meixner/RUNDIRS/twcda01/gdas.2021032412/gdasfcst.2021032412/fcst.548096/ice_in

There is one difference between GDAS and GFS runs:
https://github.com/NOAA-EMC/global-workflow/blob/develop/ush/parsing_namelists_CICE.sh#L74-L78

So I don't know if maybe the new CICE_hist_suffix should also have a GFS/GDAS setting? @DeniseWorthen @NickSzapiro-NOAA any chance you might have insight to this?

@emcbot emcbot added CI-Hercules-Failed **Bot use only** CI testing on Hercules for this PR has failed and removed CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress labels Dec 9, 2024
@emcbot
Copy link

emcbot commented Dec 9, 2024

Experiment C96_atm3DVar FAILED on Hercules in Build# 1 in
/work2/noaa/global/CI/HERCULES/3145/RUNTESTS/EXPDIR/C96_atm3DVar_8020fc79

@emcbot
Copy link

emcbot commented Dec 9, 2024

Experiment C48_S2SWA_gefs FAILED on Hercules in Build# 1 in
/work2/noaa/global/CI/HERCULES/3145/RUNTESTS/EXPDIR/C48_S2SWA_gefs_8020fc79

@emcbot
Copy link

emcbot commented Dec 9, 2024

Experiment C96_S2SWA_gefs_replay_ics FAILED on Hercules in Build# 1 in
/work2/noaa/global/CI/HERCULES/3145/RUNTESTS/EXPDIR/C96_S2SWA_gefs_replay_ics_8020fc79

@emcbot
Copy link

emcbot commented Dec 9, 2024

Experiment C48_ATM FAILED on Hercules in Build# 1 in
/work2/noaa/global/CI/HERCULES/3145/RUNTESTS/EXPDIR/C48_ATM_8020fc79

@emcbot
Copy link

emcbot commented Dec 9, 2024

Experiment C96C48_hybatmDA FAILED on Hercules in Build# 1 in
/work2/noaa/global/CI/HERCULES/3145/RUNTESTS/EXPDIR/C96C48_hybatmDA_8020fc79

@emcbot
Copy link

emcbot commented Dec 9, 2024

Experiment C48_S2SW FAILED on Hercules in Build# 1 in
/work2/noaa/global/CI/HERCULES/3145/RUNTESTS/EXPDIR/C48_S2SW_8020fc79

@emcbot emcbot added CI-Hercules-Failed **Bot use only** CI testing on Hercules for this PR has failed and removed CI-Hercules-Failed **Bot use only** CI testing on Hercules for this PR has failed labels Dec 9, 2024
@WalterKolczynski-NOAA
Copy link
Contributor

Holding off the rest of the machines until the WW3_restart_from_binary thing is worked out.

@emcbot emcbot added CI-Hercules-Passed **Bot use only** CI testing on Hercules for this PR has completed successfully and removed CI-Hercules-Passed **Bot use only** CI testing on Hercules for this PR has completed successfully labels Dec 13, 2024
@emcbot
Copy link

emcbot commented Dec 13, 2024

CI Passed on Hercules in Build# 3
Built and ran in directory /work2/noaa/global/CI/HERCULES/3145


Experiment C48_ATM_32ec7b29 Completed 2 Cycles: *SUCCESS* at Tue Dec 10 16:29:45 CST 2024
Experiment C96_atm3DVar_32ec7b29 Completed 3 Cycles: *SUCCESS* at Tue Dec 10 19:00:57 CST 2024
Experiment C96C48_hybatmDA_32ec7b29 Completed 3 Cycles: *SUCCESS* at Tue Dec 10 19:01:13 CST 2024
Experiment C96_S2SWA_gefs_replay_ics_32ec7b29 Completed 1 Cycles: *SUCCESS* at Tue Dec 10 22:46:56 CST 2024
Experiment C48_S2SW_32ec7b29 Completed 2 Cycles: *SUCCESS* at Thu Dec 12 19:29:29 CST 2024
Experiment C48_S2SWA_gefs_32ec7b29 Completed 1 Cycles: *SUCCESS* at Thu Dec 12 22:31:06 CST 2024

@JessicaMeixner-NOAA
Copy link
Contributor Author

WW3_restart_from_binary

done.

@WalterKolczynski-NOAA WalterKolczynski-NOAA added CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Wcoss2-Building **Bot use only** CI testing is cloning/building on WCOSS labels Dec 13, 2024
@emcbot emcbot added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera labels Dec 13, 2024
@WalterKolczynski-NOAA WalterKolczynski-NOAA added CI-Wcoss2-Running **Bot use only** CI testing on WCOSS for this PR is in-progress and removed CI-Wcoss2-Building **Bot use only** CI testing is cloning/building on WCOSS labels Dec 13, 2024
@WalterKolczynski-NOAA
Copy link
Contributor

CI Tests set up to run in /lfs/h2/emc/ptmp/walter.kolczynski/PR/PR_3145/RUNTESTS on WCOSS

@emcbot emcbot added CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully and removed CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress labels Dec 13, 2024
@emcbot
Copy link

emcbot commented Dec 13, 2024

CI Passed on Hera in Build# 4
Built and ran in directory /scratch1/NCEPDEV/global/CI/3145


Experiment C48mx500_3DVarAOWCDA_75a6d3c8 Completed 2 Cycles: *SUCCESS* at Fri Dec 13 19:10:53 UTC 2024
Experiment C48_ATM_75a6d3c8 Completed 2 Cycles: *SUCCESS* at Fri Dec 13 19:16:59 UTC 2024
Experiment C96_S2SWA_gefs_replay_ics_75a6d3c8 Completed 1 Cycles: *SUCCESS* at Fri Dec 13 19:29:39 UTC 2024
Experiment C96_atm3DVar_75a6d3c8 Completed 3 Cycles: *SUCCESS* at Fri Dec 13 20:35:59 UTC 2024
Experiment C96C48_hybatmDA_75a6d3c8 Completed 3 Cycles: *SUCCESS* at Fri Dec 13 20:36:04 UTC 2024
Experiment C96C48_hybatmaerosnowDA_75a6d3c8 Completed 3 Cycles: *SUCCESS* at Fri Dec 13 20:36:05 UTC 2024
Experiment C96C48_ufs_hybatmDA_75a6d3c8 Completed 3 Cycles: *SUCCESS* at Fri Dec 13 21:24:39 UTC 2024
Experiment C48_S2SW_75a6d3c8 Completed 2 Cycles: *SUCCESS* at Fri Dec 13 21:31:23 UTC 2024
Experiment C48_S2SWA_gefs_75a6d3c8 Completed 1 Cycles: *SUCCESS* at Fri Dec 13 22:02:45 UTC 2024

@WalterKolczynski-NOAA WalterKolczynski-NOAA added CI-Wcoss2-Passed **Bot use only** CI testing on WCOSS for this PR has completed successfully and removed CI-Wcoss2-Running **Bot use only** CI testing on WCOSS for this PR is in-progress labels Dec 14, 2024
@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit 93719be into NOAA-EMC:develop Dec 14, 2024
10 of 11 checks passed
sbanihash pushed a commit to sbanihash/global-workflow that referenced this pull request Dec 14, 2024
@JessicaMeixner-NOAA @sbanihash
Update ufs-weather-model to 2024-12-06 commit (NOAA-EMC#3145)
41972b6 
This PR updates ufs-weather-model hash to the latest commit which
addresses an issue seen in an earlier commit (see:
NOAA-EMC#3110)

Note this includes the PR that enables PIO for WW3, however additional
work is required to use this feature.
Another notable PR update is for a PIO finalize bug in CICE which also
required updates to ice_in

Resolves NOAA-EMC#3110
This was referenced Dec 14, 2024
Merged
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeniseWorthen DeniseWorthen DeniseWorthen left review comments

@aerorahul aerorahul aerorahul left review comments

@WalterKolczynski-NOAA WalterKolczynski-NOAA WalterKolczynski-NOAA approved these changes

@DavidHuber-NOAA DavidHuber-NOAA DavidHuber-NOAA left review comments

@junwang-noaa junwang-noaa Awaiting requested review from junwang-noaa junwang-noaa is a code owner

@KateFriedman-NOAA KateFriedman-NOAA Awaiting requested review from KateFriedman-NOAA KateFriedman-NOAA is a code owner

Assignees
No one assigned
Labels
CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully CI-Hercules-Passed **Bot use only** CI testing on Hercules for this PR has completed successfully CI-Wcoss2-Passed **Bot use only** CI testing on WCOSS for this PR has completed successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue building pre/post wave jobs with latest ufs-weather-model
10 participants
@JessicaMeixner-NOAA @emcbot @DavidHuber-NOAA @NickSzapiro-NOAA @EricSinsky-NOAA @aerorahul @WalterKolczynski-NOAA @WenMeng-NOAA @TerrenceMcGuinness-NOAA @DeniseWorthen