-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add domain level to wave gridded COM path #3137
Open
AntonMFernando-NOAA
wants to merge
120
commits into
NOAA-EMC:develop
Choose a base branch
from
AntonMFernando-NOAA:wavegrid_compath
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add domain level to wave gridded COM path #3137
AntonMFernando-NOAA
wants to merge
120
commits into
NOAA-EMC:develop
from
AntonMFernando-NOAA:wavegrid_compath
+87
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonMFernando-NOAA
force-pushed
the
wavegrid_compath
branch
2 times, most recently
from
December 19, 2024 20:38
6ba4f73
to
34f8d72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses the organization of wave gridded products within the file structure. Currently, all wave gridded products are placed in products/wave/gridded, without any further categorization. To align with the structure used by other component products (such as grib2), this update introduces a domain/resolution directory level to group output more effectively.
For example, instead of having all products in a single directory, the structure will now include specific directories based on domain and resolution (e.g., products/wave/gridded/arctic.9km, products/wave/gridded/global.0p16). This change improves organization and scalability for wave gridded product outputs.
Resolves Add domain level to wave gridded COM path #2677
Type of change
COM_WAVE_GRID_TMPL
updated (or a new template, similar toCOM_ATMOS_GRIB_TMP
andCOM_ATMOS_GRIB_GRID_TMPL
) to include a directory level for the domain and resolutionChange characteristics
How has this been tested?
Checklist