Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up GSI analysis jobs in CI testing #3115

Conversation

CoryMartin-NOAA
Copy link
Contributor

@CoryMartin-NOAA CoryMartin-NOAA commented Nov 20, 2024

Description

This PR adds DO_TEST_MODE, which can be used for other things in the future but for now sets the GSI to run just 5 iterations per outer loop to reduce runtime for CI testing.

Resolves #3114

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? MAYBE
  • Does this change require an update to any of the following submodules? NO

How has this been tested?

  • Clone and build on Hera
  • Cycled test on Hera

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward PR. Approve ... but did not test.

@DavidHuber-NOAA DavidHuber-NOAA added the CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules label Nov 22, 2024
@emcbot emcbot added CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress and removed CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules labels Nov 22, 2024
@DavidHuber-NOAA DavidHuber-NOAA added the CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera label Nov 22, 2024
@emcbot emcbot added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera labels Nov 22, 2024
@emcbot
Copy link

emcbot commented Nov 22, 2024

Experiment C48_S2SW FAILED on Hera in Build# 2 with error logs:

/scratch1/NCEPDEV/global/CI/3115/RUNTESTS/COMROOT/C48_S2SW_0bb9078e/logs/2021032312/gfs_stage_ic.log

Follow link here to view the contents of the above file(s): (link)

@emcbot emcbot added CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed and removed CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress labels Nov 22, 2024
@emcbot
Copy link

emcbot commented Nov 22, 2024

Experiment C48_S2SW FAILED on Hera in Build# 2 in
/scratch1/NCEPDEV/global/CI/3115/RUNTESTS/EXPDIR/C48_S2SW_0bb9078e

@JessicaMeixner-NOAA
Copy link
Contributor

@WalterKolczynski-NOAA I was pointed to this failure offline because it was about a wave IC issue:

SError: unable to copy /scratch1/NCEPDEV/global/glopara/data/ICSDIR/C48mx500/20240610/gfs.20210323/06/model/wave/restart/20210323.120000.restart.ww3 to /scratch1/NCEPDEV/global/CI/3115/RUNTESTS/COMROOT/C48_S2SW_0bb9078e/gfs.20210323/06//model/wave/restart/20210323.120000.restart.ww3

I'm concerned that changes in staging of wave ICs has messed up existing regression tests in prep for #3112
removing the grid id perhaps is causing an issue because we have many wave gridids that are used in various places and what was copied to ww3? And where? I'll continue this conversation in 3112. I don't think we want to break other tests before 3112 is merged do we? And perahps we need to carefully go through and make sure ICs are properly placed for various wave grids for various CI tests. I'm unsure about this now.

@emcbot
Copy link

emcbot commented Nov 22, 2024

Experiment C48_S2SWA_gefs FAILED on Hera in Build# 2 with error logs:

/scratch1/NCEPDEV/global/CI/3115/RUNTESTS/COMROOT/C48_S2SWA_gefs_0bb9078e/logs/2021032312/gefs_stage_ic.log

Follow link here to view the contents of the above file(s): (link)

@emcbot
Copy link

emcbot commented Nov 22, 2024

Experiment C48_S2SWA_gefs FAILED on Hera in Build# 2 in
/scratch1/NCEPDEV/global/CI/3115/RUNTESTS/EXPDIR/C48_S2SWA_gefs_0bb9078e

@WalterKolczynski-NOAA
Copy link
Contributor

@WalterKolczynski-NOAA I was pointed to this failure offline because it was about a wave IC issue:

SError: unable to copy /scratch1/NCEPDEV/global/glopara/data/ICSDIR/C48mx500/20240610/gfs.20210323/06/model/wave/restart/20210323.120000.restart.ww3 to /scratch1/NCEPDEV/global/CI/3115/RUNTESTS/COMROOT/C48_S2SW_0bb9078e/gfs.20210323/06//model/wave/restart/20210323.120000.restart.ww3

I'm concerned that changes in staging of wave ICs has messed up existing regression tests in prep for #3112 removing the grid id perhaps is causing an issue because we have many wave gridids that are used in various places and what was copied to ww3? And where? I'll continue this conversation in 3112. I don't think we want to break other tests before 3112 is merged do we? And perahps we need to carefully go through and make sure ICs are properly placed for various wave grids for various CI tests. I'm unsure about this now.

A few symlinks got broken somehow. Breaking old tests was not intentional. The links are restored now.

@emcbot
Copy link

emcbot commented Nov 22, 2024

Experiment C96C48_ufs_hybatmDA FAILED on Hera in Build# 3 in
/scratch1/NCEPDEV/global/CI/3115/RUNTESTS/EXPDIR/C96C48_ufs_hybatmDA_0bb9078e

@emcbot
Copy link

emcbot commented Nov 22, 2024

Experiment C96C48_hybatmDA FAILED on Hera in Build# 3 in
/scratch1/NCEPDEV/global/CI/3115/RUNTESTS/EXPDIR/C96C48_hybatmDA_0bb9078e

@emcbot emcbot added CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed and removed CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed labels Nov 22, 2024
@emcbot
Copy link

emcbot commented Nov 22, 2024

CI Failed on Hera in Build# 3
Built and ran in directory /scratch1/NCEPDEV/global/CI/3115


Experiment C96_S2SWA_gefs_replay_ics_0bb9078e Completed 1 Cycles: *SUCCESS* at Fri Nov 22 19:26:19 UTC 2024
Experiment C96_atm3DVar_0bb9078e Terminated with 0
FAIL
FAIL tasks failed and 20 dead at Fri Nov 22 19:56:33 UTC 2024
Experiment C96_atm3DVar_0bb9078e Terminated: *FAIL*
Error logs:
/scratch1/NCEPDEV/global/CI/3115/RUNTESTS/COMROOT/C96_atm3DVar_0bb9078e/logs/2021122100/gfs_atmos_prod_f000.log
/scratch1/NCEPDEV/global/CI/3115/RUNTESTS/COMROOT/C96_atm3DVar_0bb9078e/logs/2021122100/gfs_atmos_prod_f003.log
/scratch1/NCEPDEV/global/CI/3115/RUNTESTS/COMROOT/C96_atm3DVar_0bb9078e/logs/2021122100/gfs_atmos_prod_f006.log
/scratch1/NCEPDEV/global/CI/3115/RUNTESTS/COMROOT/C96_atm3DVar_0bb9078e/logs/2021122100/gfs_atmos_prod_f009.log
/scratch1/NCEPDEV/global/CI/3115/RUNTESTS/COMROOT/C96_atm3DVar_0bb9078e/logs/2021122100/gfs_atmos_prod_f012.log
/scratch1/NCEPDEV/global/CI/3115/RUNTESTS/COMROOT/C96_atm3DVar_0bb9078e/logs/2021122100/gfs_atmos_prod_f015.log
/scratch1/NCEPDEV/global/CI/3115/RUNTESTS/COMROOT/C96_atm3DVar_0bb9078e/logs/2021122100/gfs_atmos_prod_f018.log
/scratch1/NCEPDEV/global/CI/3115/RUNTESTS/COMROOT/C96_atm3DVar_0bb9078e/logs/2021122100/gfs_atmos_prod_f021.log
/scratch1/NCEPDEV/global/CI/3115/RUNTESTS/COMROOT/C96_atm3DVar_0bb9078e/logs/2021122100/gfs_atmos_prod_f024.log
/scratch1/NCEPDEV/global/CI/3115/RUNTESTS/COMROOT/C96_atm3DVar_0bb9078e/logs/2021122100/gfs_atmos_prod_f027.log
/scratch1/NCEPDEV/global/CI/3115/RUNTESTS/COMROOT/C96_atm3DVar_0bb9078e/logs/2021122100/gfs_atmos_prod_f030.log
/scratch1/NCEPDEV/global/CI/3115/RUNTESTS/COMROOT/C96_atm3DVar_0bb9078e/logs/2021122100/gfs_atmos_prod_f033.log
/scratch1/NCEPDEV/global/CI/3115/RUNTESTS/COMROOT/C96_atm3DVar_0bb9078e/logs/2021122100/gfs_atmos_prod_f036.log
/scratch1/NCEPDEV/global/CI/3115/RUNTESTS/COMROOT/C96_atm3DVar_0bb9078e/logs/2021122100/gfs_atmos_prod_f039.log
/scratch1/NCEPDEV/global/CI/3115/RUNTESTS/COMROOT/C96_atm3DVar_0bb9078e/logs/2021122100/gfs_atmos_prod_f042.log
/scratch1/NCEPDEV/global/CI/3115/RUNTESTS/COMROOT/C96_atm3DVar_0bb9078e/logs/2021122100/gfs_atmos_prod_f045.log
/scratch1/NCEPDEV/global/CI/3115/RUNTESTS/COMROOT/C96_atm3DVar_0bb9078e/logs/2021122100/gfs_atmos_prod_f048.log
/scratch1/NCEPDEV/global/CI/3115/RUNTESTS/COMROOT/C96_atm3DVar_0bb9078e/logs/2021122100/gfs_atmos_prod_f051.log
/scratch1/NCEPDEV/global/CI/3115/RUNTESTS/COMROOT/C96_atm3DVar_0bb9078e/logs/2021122100/gfs_atmos_prod_f054.log
/scratch1/NCEPDEV/global/CI/3115/RUNTESTS/COMROOT/C96_atm3DVar_0bb9078e/logs/2021122100/gfs_atmos_prod_f057.log
Experiment C48mx500_3DVarAOWCDA_0bb9078e Completed 2 Cycles: *SUCCESS* at Fri Nov 22 20:02:37 UTC 2024
Experiment C48_ATM_0bb9078e Completed 2 Cycles: *SUCCESS* at Fri Nov 22 20:02:38 UTC 2024

@WalterKolczynski-NOAA WalterKolczynski-NOAA added CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera and removed CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed labels Nov 22, 2024
@emcbot emcbot added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera labels Nov 22, 2024
@emcbot
Copy link

emcbot commented Nov 22, 2024

Checkout Failed on Hera in Build# 5: null

1 similar comment
@emcbot
Copy link

emcbot commented Nov 22, 2024

Checkout Failed on Hera in Build# 5: null

@emcbot emcbot added CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed and removed CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera labels Nov 22, 2024
@WalterKolczynski-NOAA WalterKolczynski-NOAA added CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera and removed CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed labels Nov 22, 2024
@emcbot emcbot added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera labels Nov 22, 2024
@WalterKolczynski-NOAA WalterKolczynski-NOAA added CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera and removed CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera labels Nov 22, 2024
@emcbot emcbot added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress labels Nov 23, 2024
@emcbot
Copy link

emcbot commented Nov 23, 2024

CI Passed on Hera in Build# 7
Built and ran in directory /scratch1/NCEPDEV/global/CI/3115


Experiment C96_S2SWA_gefs_replay_ics_baccdedd Completed 1 Cycles: *SUCCESS* at Sat Nov 23 13:15:45 UTC 2024
Experiment C48mx500_3DVarAOWCDA_baccdedd Completed 2 Cycles: *SUCCESS* at Sat Nov 23 13:27:55 UTC 2024
Experiment C48_ATM_baccdedd Completed 2 Cycles: *SUCCESS* at Sat Nov 23 13:33:59 UTC 2024
Experiment C96C48_hybatmaerosnowDA_baccdedd Completed 3 Cycles: *SUCCESS* at Sat Nov 23 14:47:18 UTC 2024
Experiment C96C48_hybatmDA_baccdedd Completed 3 Cycles: *SUCCESS* at Sat Nov 23 14:47:19 UTC 2024
Experiment C48_S2SWA_gefs_baccdedd Completed 1 Cycles: *SUCCESS* at Sat Nov 23 14:48:19 UTC 2024
Experiment C96_atm3DVar_baccdedd Completed 3 Cycles: *SUCCESS* at Sat Nov 23 14:53:11 UTC 2024
Experiment C48_S2SW_baccdedd Completed 2 Cycles: *SUCCESS* at Sat Nov 23 15:23:38 UTC 2024
Experiment C96C48_ufs_hybatmDA_baccdedd Completed 3 Cycles: *SUCCESS* at Sat Nov 23 15:30:11 UTC 2024

@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit efc25be into NOAA-EMC:develop Nov 23, 2024
10 of 11 checks passed
WalterKolczynski-NOAA pushed a commit that referenced this pull request Dec 12, 2024
…est (#3120)

This PR is a companion to NOAA-EMC/GDASApp#1365

It turns ```C96C48_ufs_hybatmDA``` and ```C48mx500_3DVarAOWCDA``` into a
regression test using the JEDI application testing feature. This feature
is turned on using the new ```DO_TEST_MODE``` parameter added to
```config.base``` in GW PR
[#3115](#3115). This
parameter is set to ```"YES"``` in the yaml defaults for the JEDI-based
CI tests in GW.

The motivation for this PR is a need to catch changes in JEDI which
alter the outputs of our applications.
---------

Co-authored-by: CoryMartin-NOAA <[email protected]>
Co-authored-by: RussTreadon-NOAA <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully CI-Hercules-Passed **Bot use only** CI testing on Hercules for this PR has completed successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Speed up GSI run in CI tests
7 participants