Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the "state of ground" to increase the snow depth reports #3093

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

jiaruidong2017
Copy link
Contributor

@jiaruidong2017 jiaruidong2017 commented Nov 13, 2024

Description

This PR adds the bufr lib path for the NOAA-EMC/GDASApp#1368, which uses the python BUFR2IODA API to read the GTS bufr snow observations and adds to read the state of ground (SOGR) for bringing in the extra snow depth reports.

This PR depends on

This PR resolves #3191

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO

How has this been tested?

  • Cycled test on Hera

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

Copy link
Member

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to script looks ok but I don't see a new GDASApp hash in this PR even though it says it relies on a GDASApp repo PR. Should there be a new GDASApp hash in this PR?

@jiaruidong2017
Copy link
Contributor Author

Change to script looks ok but I don't see a new GDASApp hash in this PR even though it says it relies on a GDASApp repo PR. Should there be a new GDASApp hash in this PR?

Thanks @KateFriedman-NOAA for your review. The GDASApp PR is not ready yet. Once the GDASApp's PR is merged into develop, I will update to include GDASApp hash here. Do I need to convert this PR to draft?

@KateFriedman-NOAA
Copy link
Member

@jiaruidong2017 Understood, thanks for clarifying. Yes, please move this to draft and then mark it as ready to review once the new GDASApp hash is added to the PR. Thanks!

@jiaruidong2017 jiaruidong2017 marked this pull request as draft November 13, 2024 20:45
@RussTreadon-NOAA
Copy link
Contributor

@jiaruidong2017 : one comment & one question

  • Comment: Please open a g-w issue for this PR. g-w development should begin with an issue as per the following g-w PR guideline
  At the end of your description, please be sure to add the issue this PR solves using the word "Resolves". If there are any issues that are related but not yet resolved (including in other repos), you may use "Refs".

  Resolves #1234
  Refs #4321
  Refs NOAA-EMC/repo#5678
  • Question: This PR was opened 11/12/2024. What is this PR waiting for? When do you expect this PR to be ready for review? The answers to these questions help the g-w team with resource planning.

@jiaruidong2017
Copy link
Contributor Author

@jiaruidong2017 : one comment & one question

  • Comment: Please open a g-w issue for this PR. g-w development should begin with an issue as per the following g-w PR guideline
  At the end of your description, please be sure to add the issue this PR solves using the word "Resolves". If there are any issues that are related but not yet resolved (including in other repos), you may use "Refs".

  Resolves #1234
  Refs #4321
  Refs NOAA-EMC/repo#5678
  • Question: This PR was opened 11/12/2024. What is this PR waiting for? When do you expect this PR to be ready for review? The answers to these questions help the g-w team with resource planning.

I just opened an issue #3191 for this draft PR.

For your question, we plan to use the new developed SPOC for handling the GTS bufr data process. However, the SPOC implementation is pending with the merge of the branch IODA feature/bufr_in_parallel (JCSDA-internal/ioda PR #1300) which enable parallel processing with BUFR and Script backends. As I know, this IODA PR is waiting for the update of the spack-stack-1.9.0 before proceeding with this PR, which suppose to happen in the coming January.

@RussTreadon-NOAA
Copy link
Contributor

Add https://github.com/JCSDA-internal/ioda/pull/1300 and spack-stack/1.9.0 dependencies to PR description

@jiaruidong2017
Copy link
Contributor Author

Add JCSDA-internal/ioda#1300 and spack-stack/1.9.0 dependencies to PR description

Thanks @RussTreadon-NOAA

@RussTreadon-NOAA
Copy link
Contributor

@jiaruidong2017 , please keep this PR up to date as information becomes available regarding prerequisite PRs or other items of note. This information helps the g-w team with planning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the "state of ground" to increase the snow depth reports
3 participants