-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the "state of ground" to increase the snow depth reports #3093
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to script looks ok but I don't see a new GDASApp hash in this PR even though it says it relies on a GDASApp repo PR. Should there be a new GDASApp hash in this PR?
Thanks @KateFriedman-NOAA for your review. The GDASApp PR is not ready yet. Once the GDASApp's PR is merged into develop, I will update to include GDASApp hash here. Do I need to convert this PR to draft? |
@jiaruidong2017 Understood, thanks for clarifying. Yes, please move this to draft and then mark it as ready to review once the new GDASApp hash is added to the PR. Thanks! |
@jiaruidong2017 : one comment & one question
|
I just opened an issue #3191 for this draft PR. For your question, we plan to use the new developed SPOC for handling the GTS bufr data process. However, the SPOC implementation is pending with the merge of the branch |
Add https://github.com/JCSDA-internal/ioda/pull/1300 and |
Thanks @RussTreadon-NOAA |
@jiaruidong2017 , please keep this PR up to date as information becomes available regarding prerequisite PRs or other items of note. This information helps the g-w team with planning. |
Description
This PR adds the bufr lib path for the NOAA-EMC/GDASApp#1368, which uses the python BUFR2IODA API to read the GTS bufr snow observations and adds to read the
state of ground
(SOGR) for bringing in the extra snow depth reports.This PR depends on
spack-stack/1.9.0
This PR resolves #3191
Type of change
Change characteristics
How has this been tested?
Checklist