-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Satellite plotting fix, OMPS pairing fix, and some additional time interval looping #284
Conversation
Quick and dirty fix. A more thorough refactor will be performed after the tutorial.
…A-CSL/MELODIES-MONET into hotfix/satplots_and_aircraft
The code added by @mbruckner-work looks fine to me. Since this PR includes some of my own commits, I guess we want an independent reviewer though? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good.
@mbruckner-work and @blychs, there is a small conflict now. Will Meng's method work here for you all too? |
@rschwant It should work (and probably be a better solution than ours). |
I'm testing that Meng's update still works with the aircraft code now. Do you all want to test that it works for your satellite options? Or if you are pretty confident it will work. I can choose Meng's option. We can merge it in. And everyone can retest everything this afternoon. |
I merged Meng's version, my code works fine and I don't think this can break Maggie's, but do you want to test it, just in case, @mbruckner-work ? |
My test cases worked fine. |
Then I think it could be merged, @rschwant , unless we need another review. |
I'm worried that both of your all's fix for the filter_criteria that Quazi set up breaks the altitude feature Quazi added @quaz115. I'm looking into it. |
But I need to better understand Quazi's code to suggest a proper fix. I'm messaging him. Will fix soon. |
That's surprising. Is it breaking in the same line? Because we would expect both our previous solution and Meng's solution to not affect that, since the
should work worth for df and ds.
or, worst case scenario, for a dirty solution
|
Okay it's fine. I'm having trouble calling the logic that Quazi set up as I don't fully understand the yaml options, but we update this later. The example runs well, so this can be pulled in. |
Fixes to satplots from @blychs.
OMPS-NM level 3 ozone pairing fix necessary for calculating daily mean from model's xarray dataset.
Enables time looped processing for RAQMS model, MOPITT CO obs. Small syntax change to allow use of time looping and OMPS-NM level 2 from Suomi NPP, NOAA-20, and future OMPS-NM instruments.