Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop grid #176

Merged
merged 67 commits into from
Oct 11, 2023
Merged

Develop grid #176

merged 67 commits into from
Oct 11, 2023

Conversation

dwfncar
Copy link
Collaborator

@dwfncar dwfncar commented Apr 10, 2023

Part I of III for a possible approach to using the time chunking loop. This part is for new code up to the 'pairing' stage, keeping datasets as xarray.

dwfncar added 30 commits January 11, 2023 12:20
@dwfncar
Start on analysis_util module.
dc70fb1
@dwfncar
Start on test module for analysis_util.
c3eb5d7
@dwfncar
Add test_find_file.
903625b
@dwfncar
Added test_find_file.
d9737fe
@dwfncar
Added regrid_util module.
f62bbcb
@dwfncar
Added test_fill_date_template.
6ca1760
@dwfncar
Test julian day in fill_date_template.
5ca09dd
@dwfncar
Start on script process_grid_data.
5f9a651
@dwfncar
Start on control YAML for process_grid_data example.
7486d3d
@dwfncar
Added analysis.setup_regridders.
8cd3efa
@dwfncar
Added analysis.setup_regridders.
51e5d3a
@dwfncar
Start on read_grid_util module.
74e8a77
@dwfncar
Added get_obs_vars.
c2dd247
@dwfncar
Move get_obs_vars to analysis_util module.
39e31e8
@dwfncar
Added read_grid_util.read_grid_obs.
a7f1988
@dwfncar
Added grid_data config flag in analysis block.
a12f709
@dwfncar
Added grid_data control flag.
9f5770c
@dwfncar
Added model and obs control blocks.
e81593f
@dwfncar
Switch to monthly data.
8e3d8d7
@dwfncar
Construct date_str from time_interval in analysis.open_obs.
7f135b1
@dwfncar
Use analysis_util.get_obs_vars in analysis.open_obs.
9ea5d14
@dwfncar
Call read_grid_util.read_grid_obs in analysis.open_obs.
9d12538
@dwfncar
In open_obs, grid_obs block, assign observation object attributes.
3e01b5f
@dwfncar
Added open grid models.
1de4221
@dwfncar
Populate analysis.models.
907d487
@dwfncar
Print obs and model objs.
4adb4a5
@dwfncar
Use analysis grid_data flag.
210d56f
@dwfncar
Added observation type grid_data.
8143f1e
@dwfncar
Added model name.
13182e7
@dwfncar
Return filename from read_grid_util readers.
5f99545
dwfncar added 19 commits June 15, 2023 12:20
@dwfncar
Merge branch 'develop' into develop_grid
d17445a
@dwfncar
Added file docs/background/time_chunking.rst.
eebb0ab
@dwfncar
Renamed config option grid_data to longer time_chunking_with_gridded_…
34ed454 
…data.
@dwfncar
Moved time chunking with gridded data example to process_gridded_data…
3ef410e 
… subdir.
@dwfncar
Use filename in config instead of filestr.
e56d43c
@dwfncar
Use filename in config instead of filestr.
57a1216
@dwfncar
Refactoring time chunking option in drive.
5b520b5
@dwfncar
Revised data paths.
a2b2993
@dwfncar
Return filename from read_grid_util.read_grid_obs.
b880b4b
@dwfncar
Extract the self.obs dataset from the dictionary of datasets from rea…
b4c6797 
…d_grid_obs. Need to add option to read_grid_obs to read only a designated dataset.
@dwfncar
Added mod_type entry.
70f1655
@dwfncar
Added control_dict optional arg to model.open_model_files.
8235eeb
@dwfncar
Added time_chunking_with_gridded_data option in open_model_files.
9574748
@dwfncar
Added time_chunking_with_gridded_data block in open_model_files.
19bda7c
@dwfncar
Removed filename retrun in read_grid_util.read_grid_models.
b82d77e
@dwfncar
Updated utils/read_grid_util to allow for single model or obs to be r…
b5ac1bf 
…ead.
@dwfncar
Updated utils/read_grid_util to allow for single model or obs to be r…
9f8a609 
…ead.
@dwfncar
Return filenames in read_grid_util readers.
9fe5274
@dwfncar
Removed prototype version.
bd505b8
@dwfncar dwfncar requested a review from colin-harkins August 9, 2023 22:13
@colin-harkins
Copy link
Collaborator

Besides potentially addressing my recent comment about the if statement for time_chunking_with_gridded_data in driver.model.open_model_files(), and addressing the failing tests, I think this looks good! I'll approve once I hear back about the if statement and once the tests pass.

@dwfncar dwfncar merged commit 58b6546 into develop Oct 11, 2023
4 checks passed
@rschwant rschwant mentioned this pull request Nov 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-harkins colin-harkins colin-harkins approved these changes

@zmoon zmoon Awaiting requested review from zmoon

@rschwant rschwant Awaiting requested review from rschwant

@mebruckner mebruckner Awaiting requested review from mebruckner

@rrbuchholz rrbuchholz Awaiting requested review from rrbuchholz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dwfncar @colin-harkins