Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

putting docker files into their own folder #289

Merged
merged 1 commit into from
Oct 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/gh_pages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ jobs:

# create two copies of the documentaiton
# 1. the frozen version, represented as vX.X in the version switcher
docker build -t micm -f Dockerfile.docs .
docker build -t micm -f docker/Dockerfile.docs .
id=$(docker create micm)
docker cp $id:/build/docs/sphinx tmpdocs
docker rm -v $id
Expand All @@ -62,7 +62,7 @@ jobs:

# 2. stable, represented as vX.X (stable) in the version switcher
# edit conf.py to produce a version string that looks like vX.X (stable)
docker build -t micm -f Dockerfile.docs --build-arg SUFFIX=" (stable)" .
docker build -t micm -f docker/Dockerfile.docs --build-arg SUFFIX=" (stable)" .
id=$(docker create micm)
docker cp $id:/build/docs/sphinx tmpdocs
docker rm -v $id
Expand All @@ -83,7 +83,7 @@ jobs:
!contains(github.ref, env.DEFAULT_BRANCH)
run: |
set -x
docker build -t micm -f Dockerfile.docs .
docker build -t micm -f docker/Dockerfile.docs .
id=$(docker create micm)
docker cp $id:/build/docs/sphinx tmpdocs
docker rm -v $id
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
submodules: recursive

- name: Build Docker image
run: docker build -t micm -f ${{ matrix.dockerfile }} .
run: docker build -t micm -f docker/${{ matrix.dockerfile }} .

- name: Run tests in container
if: matrix.dockerfile != 'Dockerfile.coverage'
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ To build the latest pre-release version of MICM, instead run:
```
git clone https://github.com/NCAR/micm.git
cd micm
docker build -t micm .
docker build -t micm -f docker/Dockerfile .
docker run -it micm bash
```

Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
2 changes: 1 addition & 1 deletion docs/source/getting_started.rst
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ Docker Container

Build and run the image::

$ docker build -t micm -f Dockerfile.nvhpc .
$ docker build -t micm -f docker/Dockerfile.nvhpc .
$ docker run --rm -it micm

If you would like, you can ssh into a running docker container and edit the files there.
Expand Down