Address SciPy interp2d deprecation #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jukent
approved these changes
Oct 9, 2024
Indeed 😞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the SciPy
interp2ddeprecation by using xarray'sinterpmethod instead.Closes #607
This doesn't address the bigger issues I stumbled upon in looking into this of matplotlib's streamlines requiring input data on a regular grid (this should probably be addressed as an upstream contribution) and that these (streamlines vs NCL curly vectors) are different ways of representing data. While they look similar, they aren't showing information in the same ways and that should probably be documented. The reference vector is also incorrect. I'll log this as an issue.