-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add invariant species and add entries for the status of parameterized and advected #3
base: main
Are you sure you want to change the base?
Conversation
"name": "air", | ||
"type": "CHEM_SPEC", | ||
"absolute tolerance": 1e-12, | ||
"molecular weight [kg mol-1]": 0.0289644, | ||
"__is advected": false, | ||
"__is parameterized": false, | ||
"__is added to profile": true, | ||
"__unit" : "molecule cm-3", | ||
"__scale height [km]": 8.01 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mattldawson, Is it okay to include air in the species.json? The goal is to avoid hardcoding the gas species in atmospheric physics configuration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's fine, if CAM-SIMA expects air to be in the constituents array. I would just add a "tracer type": "CONSTANT"
so that the solver doesn't treat it as a variable to be solved for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, thank you! I will fix that. Hi @nusbaume, @peverwhee and @jimmielin, is it acceptable to add air into the constituent array?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @boulderdaze, I also believe that should be fine, but it might be good to call it dry_air
or something like that ( assuming it is not including H2O as part of the mixture, which CAM-SIMA might complain about). Of course if that doesn't work for you please let me know!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'll use dry_air
. Thank you for your suggestion!
Closes #2