Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: remove non-working and unused tests for state IO #779

Merged
merged 3 commits into from
Dec 6, 2024

Conversation

hkershaw-brown
Copy link
Member

Description:

Removes IO dev tests.
Not used, out-of-date, or do not run (#106)

Fixes issue

fixes #106 (removes dead code)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Removes dead code

Documentation changes needed?

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

Tests

Please describe any tests you ran to verify your changes.
Built everything in dart to to confirm nothing is using the io test code:
https://github.com/NCAR/DART/actions/runs/12162207342
(note GOES failing is rttov 13 not in the container: NCAR/DART-containers#1)

Checklist for merging

  • Updated changelog entry
  • Documentation updated
  • Update conf.py

Checklist for release

  • Merge into main
  • Create release from the main branch with appropriate tag
  • Delete feature-branch

Testing Datasets

  • Dataset needed for testing available upon request
  • Dataset download instructions included
  • No dataset needed

Copy link
Contributor

@mjs2369 mjs2369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean removal, approved

@hkershaw-brown hkershaw-brown added the release! bundle with next release label Dec 5, 2024
@hkershaw-brown hkershaw-brown merged commit bddda57 into main Dec 6, 2024
4 checks passed
@hkershaw-brown hkershaw-brown deleted the remove-IO-dev-tests branch December 6, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release! bundle with next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

state structure has not been tested yet with new naming conventions.
2 participants