Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aether cube sphere interface #666

Open
wants to merge 34 commits into
base: main
Choose a base branch
from
Open

Aether cube sphere interface #666

wants to merge 34 commits into from

Conversation

johnsonbk
Copy link
Collaborator

Description:

This feature branch contains the code for the aether_cube_sphere interface to DART. Completion of this interface is part of the deliverables for the funded project NSF20-519 Aether: A Flexible Community-Based Upper Atmosphere Ensemble Prediction System.

Fixes issue

This feature branch implements an interface to the Aether cube_sphere, addressing Issue #665.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Documentation changes needed?

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

Tests

  1. The model_mod passes all 7 tests in model-mod_check.
  2. A link to restart block files are included in the documentation. A complete cycle of aether_to_dart, filter, and dart_to_aether runs without issue.
  3. create_geometry_file runs and creates an appropriate geometry_file.nc needed by the model_mod.

Checklist for merging

  • Updated changelog entry
  • Documentation updated
  • Update conf.py

Checklist for release

  • Merge into main
  • Create release from the main branch with appropriate tag
  • Delete feature-branch

Testing Datasets

  • Dataset download instructions included in the readme.rst with a link to all of the necessary files needed to run model_mod_check, aether_to_dart, dart_to_aether, create_geometry_file and filter.

johnsonbk and others added 30 commits February 21, 2024 13:30
… the model domain so that model mod check #4 passes
and to supported models
Also added aether_lat-lon (missed from pull #635
ReST rule on not having duplicate names for explicit targets
aether_cube_sphere/readme.rst:2: WARNING: Duplicate explicit target name: "this link".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants