New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/247 global filter UI #249

Merged

jvigliotta merged 6 commits into NASA-AMMOS:release/5.3.0 from mudinthewater:fix/247-global-filter-ui

Dec 14, 2024

+34 −12

Contributor

mudinthewater commented Dec 12, 2024 •

edited

Loading

Pull request adds:

Documentation describing the filtering fields in config.js
Ability to modify the default field shown for a filtering drop down.
Bugfix in filtering UI caused by trying to clone a proxy object.
Change in filtering from 'small' form to 'fit' form.
Changes lodash imports back so they work with the recommended 'git clone -> npm install' workflow in README.

Peter Di Pasquale added 2 commits

December 12, 2024 14:49


          Updated filtering documentation. Added defaultLabel to filtering and …

7e46dc6

…vue field. Changed filtering UI to use 'fit' instead of 'small' UI. Fixed issue cloning proxied objects.


          Updated lodash imports to import from base 'lodash' because a raw git…

0e7fccc

… clone -> npm install currently errors out.

Contributor Author

mudinthewater commented Dec 12, 2024

This pull request fixes #247 and #239


          Merge branch 'release/5.3.0' into fix/247-global-filter-ui

f4013e6

jvigliotta reviewed

View reviewed changes

src/globalFilters/FilterField.vue Outdated Show resolved Hide resolved

jvigliotta reviewed

View reviewed changes

config.js Show resolved Hide resolved

jvigliotta reviewed

View reviewed changes

config.js Show resolved Hide resolved

jvigliotta reviewed

View reviewed changes

src/globalFilters/GlobalFilterSelector.vue Show resolved Hide resolved

jvigliotta reviewed

View reviewed changes

src/services/filtering/FilterService.js Outdated Show resolved Hide resolved

jvigliotta reviewed

View reviewed changes

src/services/filtering/FilterUrlHandler.js Outdated Show resolved Hide resolved

jvigliotta requested changes

View reviewed changes

Collaborator

jvigliotta left a comment

This is AWESOME work! Thank you for doing this, it all looks really good, I have a couple requested changes.

Peter Di Pasquale added 3 commits

December 13, 2024 12:04


          Added spaces between imports.

9cf8bf0


          Updated vue dropdown logic to remove v-if and improve code readability.

94031f6


          Removed logic from vue statements for readaibility.

d8920ad

sonarqubecloud bot commented Dec 13, 2024

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

jvigliotta self-requested a review

December 13, 2024 23:18

Collaborator

jvigliotta commented Dec 13, 2024

@davetsay let's get your peepers on this

davetsay requested changes

View reviewed changes

Collaborator

davetsay left a comment

Thanks for the help, @mudinthewater! One comment about a Vue-ism.

src/globalFilters/GlobalFilterSelector.vue Show resolved Hide resolved

src/globalFilters/FilterField.vue Show resolved Hide resolved

config.js Show resolved Hide resolved

davetsay self-requested a review

December 14, 2024 00:23

davetsay approved these changes

View reviewed changes

jvigliotta approved these changes

View reviewed changes

Collaborator

jvigliotta left a comment

iIce! Great work @mudinthewater !

jvigliotta merged commit d8a644b into NASA-AMMOS:release/5.3.0

4 checks passed

mudinthewater deleted the fix/247-global-filter-ui branch

December 15, 2024 00:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet