[Security] Remove Identity Plugin (#191)

NASA-AMMOS · Aug 22, 2024 · 6be4a68 · 6be4a68
1 parent 872d521
commit 6be4a68
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 160 deletions.
diff --git a/src/AMMOSPlugins.js b/src/AMMOSPlugins.js
@@ -6,7 +6,6 @@ define([
     './taxonomy/plugin',
     './time/plugin',
     'services/time/vistaTime',
-    './identity/plugin',
     './historical/plugin',
     './realtime/plugin',
     './link/plugin',
@@ -41,7 +40,6 @@ define([
     TaxonomyPlugin,
     TimePlugin,
     getVistaTime,
-    IdentityPlugin,
     HistoricalTelemetryPlugin,
     RealtimeTelemetryPlugin,
     LinkPlugin,
@@ -92,10 +90,7 @@ define([
             });
             openmct.install(RealtimeIndicatorPlugin.default(vistaTime));
 
-            const identityPlugin = new IdentityPlugin(options);
-            openmct.install(identityPlugin);
-
-            mcwsClient.default.configure(options, identityPlugin.login);
+            mcwsClient.default.configure(options);
 
             openmct.install(MultipleHistoricalSessions.default(options.tablePerformanceOptions));
             openmct.install(RealtimeSessions.default());

diff --git a/src/identity/LoginService.js b/src/identity/LoginService.js
diff --git a/src/identity/close.html b/src/identity/close.html
diff --git a/src/identity/plugin.js b/src/identity/plugin.js
diff --git a/src/services/mcws/MCWSClient.js b/src/services/mcws/MCWSClient.js
@@ -5,9 +5,8 @@ class MCWSClient {
         this._updatePending = this._updatePending.bind(this);
     }
 
-    configure(config, login) {
+    configure(config) {
         this.config = config;
-        this.login = login;
     }
 
     proxyRequest(options) {
@@ -86,35 +85,13 @@ class MCWSClient {
         return this.proxyRequest(options);
     };
 
-    isCamResponse(response) {
-        const contentType = response?.headers?.['content-type'];
-
-        return contentType?.includes('text/html');
-    }
-
-    getResponseType(response) {
-        // TODO: more nuanced response handling should be done here
-        if (this.isCamResponse(response)) {
-            return 'cam';
-        } else {
-            return 'unhandled';
-        }
-    }
-
     async authorizedRequest(options) {
         let response;
         const url = options.url;
         delete options.url;
 
         try {
             response = await this.baseRequest(url, options);
-            const responseType = this.getResponseType(response);
-
-            if (responseType === 'cam') {
-                await this.login();
-
-                response = await this.baseRequest(url, options);
-            }
         } catch(error) {
             return Promise.reject(error);
         }