Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E Tests: Provide Auth Header when Uploading Model JAR #1493

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

Mythicaeda
Copy link
Contributor

  • Tickets addressed: Hotfix
  • Review: By commit
  • Merge strategy: Merge (no squash)

Description

The Gateway has been updated to (correctly) validate that the user has an active, valid session when hitting restricted endpoints. As a consequence, the E2E tests now provide an Authorization header when uploading mission model JARs.

Verification

Ran e2eTests and did not get an "Unauthorized" error, which is the current behavior on develop

@Mythicaeda Mythicaeda added the test Adding missing tests, correcting existing tests, or test infrastructure label Jun 27, 2024
@Mythicaeda Mythicaeda added this to the FY24 Q3 - Bug Fixes milestone Jun 27, 2024
@Mythicaeda Mythicaeda requested a review from skovati June 27, 2024 21:59
@Mythicaeda Mythicaeda self-assigned this Jun 27, 2024
@Mythicaeda Mythicaeda requested a review from a team as a code owner June 27, 2024 21:59
@Mythicaeda Mythicaeda requested a review from joswig June 27, 2024 21:59
@Mythicaeda Mythicaeda changed the title Fetch and provide auth header when uploading model JAR E2E Tests: Provide Auth Header when Uploading Model JAR Jun 27, 2024
@Mythicaeda Mythicaeda force-pushed the fix/login-in-e2e-tests branch from 75a2615 to 8dd4354 Compare June 27, 2024 22:31
The Gateway has been updated to (correctly) validate that the user has an active, valid session when hitting restricted endpoints. As a consequence, the E2E tests now provide an `Authorization` header when uploading mission model JARs
@Mythicaeda Mythicaeda merged commit d6fecb1 into develop Jul 1, 2024
6 checks passed
@Mythicaeda Mythicaeda deleted the fix/login-in-e2e-tests branch July 1, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Adding missing tests, correcting existing tests, or test infrastructure
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants